language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-08-03 03:42:17 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Only permit shadowing past first pattern

Browse source
This commit is contained in:
Ayaz Hafiz 2022-07-21 14:35:16 -04:00
parent 0259c3cf92
commit 961cff94d1
No known key found for this signature in database
GPG key ID: 0E2A37416A25EF58
1 changed files with 4 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

7
crates/compiler/can/src/expr.rs
View file

@ -1335,8 +1335,9 @@ fn canonicalize_when_branch<'a>(
let mut patterns = Vec::with_capacity(branch.patterns.len());
let mut multi_pattern_variables = MultiPatternVariables::new(branch.patterns.len());
// TODO report symbols not bound in all patterns
for loc_pattern in branch.patterns.iter() {
for (i, loc_pattern) in branch.patterns.iter().enumerate() {
let permit_shadows = PermitShadows(i > 0); // patterns can shadow symbols defined in the first pattern.
let can_pattern = canonicalize_pattern(
env,
var_store,
@ -1345,7 +1346,7 @@ fn canonicalize_when_branch<'a>(
WhenBranch,
&loc_pattern.value,
loc_pattern.region,
PermitShadows(true),
permit_shadows,
);
multi_pattern_variables.add_pattern(&can_pattern);