language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-08-04 04:08:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

Fix shut_down_worker_threads! in presence of panic

Browse source
This commit is contained in:
Richard Feldman 2023-10-14 16:37:54 -04:00
parent 8ee88ba7cb
commit 97f252c68b
No known key found for this signature in database
GPG key ID: F1F21AA5B1D9E43B
1 changed files with 7 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

12
crates/compiler/load_internal/src/file.rs
View file

@ -1776,11 +1776,13 @@ fn load_multi_threaded<'a>(
macro_rules! shut_down_worker_threads {
() => {
for listener in worker_listeners {
listener.send(WorkerMsg::Shutdown).map_err(|_| {
LoadingProblem::ChannelProblem(
ChannelProblem::FailedToSendWorkerShutdownMsg,
)
})?;
// We intentionally don't propagate this Result, because even if
// shutting down a worker failed (which can happen if a a panic
// occurred on that thread), we want to continue shutting down
// the others regardless.
if listener.send(WorkerMsg::Shutdown).is_err() {
log!("There was an error trying to shutdown a worker thread. One reason this can happen is if the thread panicked.");
}
}
};
}