language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-09-26 13:29:12 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Merge pull request #4896 from roc-lang/expect-crash

Browse source 
reproduce crash in `expect` with Lists of different length
This commit is contained in:
Folkert de Vries 2023-01-14 16:53:52 +01:00 • committed by GitHub
commit 9a86e7e080
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 185 additions and 22 deletions
Download patch file Download diff file Expand all files Collapse all files

10
crates/repl_expect/src/app.rs
View file

@ -17,7 +17,15 @@ macro_rules! deref_number {
}
impl ReplAppMemory for ExpectMemory {
deref_number!(deref_bool, bool);
fn deref_bool(&self, addr: usize) -> bool {
let ptr = unsafe { self.start.add(addr) } as *const u8;
let value = unsafe { std::ptr::read_unaligned(ptr) };
// bool values should only ever be 0 or 1
debug_assert!(value == 0 || value == 1);
value != 0
}
deref_number!(deref_u8, u8);
deref_number!(deref_u16, u16);

124
crates/repl_expect/src/lib.rs
View file

@ -975,4 +975,128 @@ mod test {
),
);
}
#[test]
fn adjacent_lists() {
run_expect_test(
indoc!(
r#"
interface Test exposes [] imports []
expect
actual : { headers: List U8, body: List U8, x: List U8 }
actual = {
body: [],
headers: [],
x: [],
}
expected : { headers: List U8, body: List U8, x: List U8 }
expected = {
body: [ 42, 43, 44 ],
headers: [15, 16, 17],
x: [115, 116, 117],
}
actual == expected
"#
),
indoc!(
r#"
This expectation failed:
3│> expect
4│> actual : { headers: List U8, body: List U8, x: List U8 }
5│> actual = {
6│> body: [],
7│> headers: [],
8│> x: [],
9│> }
10│>
11│> expected : { headers: List U8, body: List U8, x: List U8 }
12│> expected = {
13│> body: [ 42, 43, 44 ],
14│> headers: [15, 16, 17],
15│> x: [115, 116, 117],
16│> }
17│> actual == expected
When it failed, these variables had these values:
actual : {
body : List (Int Unsigned8),
headers : List (Int Unsigned8),
x : List (Int Unsigned8),
}
actual = { body: [], headers: [], x: [] }
expected : {
body : List (Int Unsigned8),
headers : List (Int Unsigned8),
x : List (Int Unsigned8),
}
expected = { body: [42, 43, 44], headers: [15, 16, 17], x: [115, 116, 117] }
"#
),
);
}
#[test]
fn record_field_ordering() {
run_expect_test(
indoc!(
r#"
interface Test exposes [] imports []
Request : {
fieldA : [Get, Post],
fieldB : Str,
}
expect
actual : Request
actual = {
fieldA: Get,
fieldB: "/things?id=2",
}
expected : Request
expected = {
fieldA: Get,
fieldB: "/things?id=1",
}
actual == expected
"#
),
indoc!(
r#"
This expectation failed:
8│> expect
9│>
10│> actual : Request
11│> actual = {
12│> fieldA: Get,
13│> fieldB: "/things?id=2",
14│> }
15│>
16│> expected : Request
17│> expected = {
18│> fieldA: Get,
19│> fieldB: "/things?id=1",
20│> }
21│> actual == expected
When it failed, these variables had these values:
actual : Request
actual = { fieldA: Get, fieldB: "/things?id=2" }
expected : Request
expected = { fieldA: Get, fieldB: "/things?id=1" }
"#
),
);
}
}