language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-10-03 16:44:33 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Correct refcounting check to be recursive through aggregate types

Browse source
This commit is contained in:
Brendan Hansknecht 2024-04-07 11:08:27 -07:00
parent 951cb1ef3d
commit 9b6798ead1
No known key found for this signature in database
GPG key ID: 0EA784685083E75B
2 changed files with 3 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
crates/compiler/gen_llvm/src/llvm/build_list.rs
View file

@ -104,7 +104,7 @@ pub(crate) fn layout_refcounted<'a, 'ctx>(
) -> BasicValueEnum<'ctx> { ) -> BasicValueEnum<'ctx> {
let is_refcounted = layout_interner let is_refcounted = layout_interner
.get_repr(layout) .get_repr(layout)
.is_refcounted(layout_interner); .contains_refcounted(layout_interner);
env.context env.context
.bool_type() .bool_type()
.const_int(is_refcounted as u64, false) .const_int(is_refcounted as u64, false)

2
crates/roc_std/src/lib.rs
View file

@ -556,6 +556,8 @@ impl Hash for U128 {
} }
/// All Roc types that are refcounted must implement this trait. /// All Roc types that are refcounted must implement this trait.
///
/// For aggregate types, this must recurse down the structure.
pub trait RocRefcounted { pub trait RocRefcounted {
/// Increments the refcount n times. /// Increments the refcount n times.
fn inc(&mut self, n: usize); fn inc(&mut self, n: usize);