language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-09-27 05:49:08 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Revert "WIP fix for zig functions returning Bool (strEqual)"

Browse source 
This reverts commit 09b01893c6.
This commit is contained in:
Folkert 2023-04-08 16:11:12 +02:00
parent 09b01893c6
commit 9dd69f6f9c
No known key found for this signature in database
GPG key ID: 1F17F6FFD112B97C
7 changed files with 12 additions and 51 deletions
Download patch file Download diff file Expand all files Collapse all files

2
crates/compiler/gen_dev/src/generic64/mod.rs
View file

@ -1201,7 +1201,7 @@ impl<
ASM::eq_reg64_reg64_reg64(&mut self.buf, dst_reg, src1_reg, src2_reg);
}
Layout::STR => {
// use a zig call. This is a bit weird because the dev backend does not handle
// use a zig call
self.build_fn_call(
dst,
bitcode::STR_EQUAL.to_string(),

26
crates/compiler/gen_dev/src/generic64/storage.rs
View file

@ -349,16 +349,10 @@ impl<
self.free_reference(sym);
reg
}
Stack(Complex { size, base_offset }) => {
if size <= 8 {
let reg = self.get_general_reg(buf);
ASM::mov_reg64_base32(buf, reg, base_offset);
reg
} else {
internal_error!(
"Cannot load large values (size {size}) into general registers: {sym:?}",
)
}
Stack(Complex { size, .. }) => {
internal_error!(
"Cannot load large values (size {size}) into general registers: {sym:?}",
)
}
NoData => {
internal_error!("Cannot load no data into general registers: {}", sym)
@ -477,14 +471,10 @@ impl<
ASM::movzx_reg64_base32(buf, reg, *base_offset, *size as u8)
}
}
Stack(Complex { size, base_offset }) => {
if *size <= 8 {
ASM::mov_reg64_base32(buf, reg, *base_offset);
} else {
internal_error!(
"Cannot load large values (size {size}) into general registers: {sym:?}",
)
}
Stack(Complex { size, .. }) => {
internal_error!(
"Cannot load large values (size {size}) into general registers: {sym:?}",
)
}
NoData => {
internal_error!("Cannot load no data into general registers: {:?}", sym)