language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-09-26 21:39:07 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

clarify todo about renabling morphic and perf

Browse source
This commit is contained in:
Brendan Hansknecht 2024-12-14 10:31:05 -08:00
parent 1830b3a1f4
commit 9fd65ff41b
No known key found for this signature in database
GPG key ID: 0EA784685083E75B
1 changed files with 7 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

7
crates/compiler/alias_analysis/src/lib.rs
View file

@ -360,6 +360,13 @@ where
OptLevel::Development | OptLevel::Normal => morphic_lib::solve_trivial(program),
// TODO(#7367): Change this back to `morphic_lib::solve`.
// For now, using solve_trivial to avoid bug with loops.
// Note: when disabling this, there was not much of a change in performance.
// Notably, NQueens was about 5% slower. False interpreter was 0-5% faster (depending on input).
// cFold and derive saw minor gains ~1.5%. rBTreeCk saw a big gain of ~4%.
// This feels wrong, morphic should not really be able to slow down code.
// Likely, noise or the bug and wrong inplace mutation lead to these perf changes.
// When re-enabling this, we should analysis the perf and inplace mutations of a few apps.
// It might be the case that our current benchmarks just aren't affected by morphic much.
OptLevel::Optimize | OptLevel::Size => morphic_lib::solve_trivial(program),
}
}