language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-09-26 21:39:07 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

treat platform-switching similarly to benchmarks

Browse source
This commit is contained in:
Bryce Miller 2022-09-02 10:44:29 -04:00
parent 780945061f
commit a1543b5cc4
No known key found for this signature in database
GPG key ID: 46B3D9909ED7FB90
1 changed files with 25 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

39
crates/cli/tests/cli_run.rs
View file

@ -822,26 +822,35 @@ mod cli_run {
let example_dir_name = entry.file_name().into_string().unwrap(); let example_dir_name = entry.file_name().into_string().unwrap();
// TODO: Improve this with a more-dynamic approach. (Read all subdirectories?) // TODO: Improve this with a more-dynamic approach. (Read all subdirectories?)
// Some platform-switching examples live in nested directories // Some platform-switching examples live in nested directories, and
// the rocLovesFoo.roc examples live directly under the platform-switching directory
if example_dir_name == "platform-switching" { if example_dir_name == "platform-switching" {
for sub_dir in [ // The subdirectory checks broke when we moved the rodLovesFoo.roc examples
// We exclude the C platforming switching example // Treating the platform-switching directory similarly to the benchmarks directory for now
// because the main platform switching example runs the c platform.
// If we don't a race condition leads to test flakiness. all_examples.remove(example_dir_name.as_str()).unwrap_or_else(|| {
// "c-platform", panic!("The example directory {}/{} does not have any corresponding tests in cli_run. Please add one, so if it ever stops working, we'll know about it right away!", examples_dir, example_dir_name);
"rust-platform",
"swift-platform",
"web-assembly-platform",
"zig-platform",
] {
all_examples.remove(format!("{}/{}", example_dir_name, sub_dir).as_str()).unwrap_or_else(|| {
panic!("The example directory {}/{}/{} does not have any corresponding tests in cli_run. Please add one, so if it ever stops working, we'll know about it right away!", examples_dir, example_dir_name, sub_dir);
}); });
}
// for sub_dir in [
// // We exclude the C platforming switching example
// // because the main platform switching example runs the c platform.
// // If we don't a race condition leads to test flakiness.
// // "c-platform",
// "rust-platform",
// "swift-platform",
// "web-assembly-platform",
// "zig-platform",
// ] {
// all_examples.remove(format!("{}/{}", example_dir_name, sub_dir).as_str()).unwrap_or_else(|| {
// panic!("The example directory {}/{}/{} does not have any corresponding tests in cli_run. Please add one, so if it ever stops working, we'll know about it right away!", examples_dir, example_dir_name, sub_dir);
// });
// }
} }
// We test benchmarks separately // We test benchmarks separately
if example_dir_name != "benchmarks" { // platform-switching examples are handled above
if example_dir_name != "benchmarks" && example_dir_name != "platform-switching" {
all_examples.remove(example_dir_name.as_str()).unwrap_or_else(|| { all_examples.remove(example_dir_name.as_str()).unwrap_or_else(|| {
panic!("The example directory {}/{} does not have any corresponding tests in cli_run. Please add one, so if it ever stops working, we'll know about it right away!", examples_dir, example_dir_name); panic!("The example directory {}/{} does not have any corresponding tests in cli_run. Please add one, so if it ever stops working, we'll know about it right away!", examples_dir, example_dir_name);
}); });