language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-09-27 22:09:09 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

refactoring trivial copy detection

Browse source
This commit is contained in:
Folkert 2022-05-21 13:48:28 +02:00
parent a705d6a6e8
commit a1894195d3
No known key found for this signature in database
GPG key ID: 1F17F6FFD112B97C
2 changed files with 20 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

21
compiler/solve/src/solve.rs
View file

@ -3040,6 +3040,19 @@ fn deep_copy_var_in(
copy
}
#[inline]
fn has_trivial_copy(subs: &Subs, root_var: Variable) -> Option<Variable> {
let existing_copy = subs.get_copy_unchecked(root_var);
if let Some(copy) = existing_copy.into_variable() {
Some(copy)
} else if subs.get_rank_unchecked(root_var) != Rank::NONE {
Some(root_var)
} else {
None
}
}
fn deep_copy_var_help(
subs: &mut Subs,
max_rank: Rank,
@ -3051,13 +3064,11 @@ fn deep_copy_var_help(
use roc_types::subs::FlatType::*;
let subs_len = subs.len();
let var = subs.get_root_key(var);
let existing_copy = subs.get_copy(var);
if let Some(copy) = existing_copy.into_variable() {
// either this variable has been copied before, or does not have NONE rank
if let Some(copy) = has_trivial_copy(subs, var) {
return copy;
} else if subs.get_rank(var) != Rank::NONE {
return var;
}
visited.push(var);