From bb180db30f9646876ca3ec1ca229bc5c3c4b4ce4 Mon Sep 17 00:00:00 2001 From: Ayaz <20735482+ayazhafiz@users.noreply.github.com> Date: Tue, 26 Apr 2022 22:42:17 -0400 Subject: [PATCH 1/2] Fix a typo from AArch64-related bugfix --- compiler/gen_llvm/src/llvm/build.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/compiler/gen_llvm/src/llvm/build.rs b/compiler/gen_llvm/src/llvm/build.rs index ee0f07f57b..4b9989c3dd 100644 --- a/compiler/gen_llvm/src/llvm/build.rs +++ b/compiler/gen_llvm/src/llvm/build.rs @@ -6270,8 +6270,8 @@ pub struct FunctionSpec<'ctx> { /// We only care about this for C-call-conv functions, because this may take /// ownership of a register due to the convention. For example, on AArch64, /// values returned-by-pointer use the x8 register. - /// But for internal functions we need to worry about that and we don't want - /// that, since it might eat a register and cause a spill! + /// But for internal functions we don't need to worry about that and we don't + /// the convention, since it might eat a register and cause a spill! cconv_sret_parameter: Option, } From b8ad2aedb4a889972d049fac54a8752cb51ca094 Mon Sep 17 00:00:00 2001 From: Ayaz <20735482+ayazhafiz@users.noreply.github.com> Date: Tue, 26 Apr 2022 22:43:04 -0400 Subject: [PATCH 2/2] Update build.rs --- compiler/gen_llvm/src/llvm/build.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/compiler/gen_llvm/src/llvm/build.rs b/compiler/gen_llvm/src/llvm/build.rs index 4b9989c3dd..219ca9a4e2 100644 --- a/compiler/gen_llvm/src/llvm/build.rs +++ b/compiler/gen_llvm/src/llvm/build.rs @@ -6271,7 +6271,7 @@ pub struct FunctionSpec<'ctx> { /// ownership of a register due to the convention. For example, on AArch64, /// values returned-by-pointer use the x8 register. /// But for internal functions we don't need to worry about that and we don't - /// the convention, since it might eat a register and cause a spill! + /// want the convention, since it might eat a register and cause a spill! cconv_sret_parameter: Option, }