language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-10-01 15:51:12 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

prevent intermediate allocation

Browse source
This commit is contained in:
Folkert 2022-04-25 21:02:45 +02:00
parent 945305fc2b
commit a26fa4559a
No known key found for this signature in database
GPG key ID: 1F17F6FFD112B97C
1 changed files with 4 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

15
compiler/can/src/def.rs
View file

@ -225,25 +225,18 @@ pub(crate) fn canonicalize_defs<'a>(
// to itself won't be processed until after its def has been added to scope. // to itself won't be processed until after its def has been added to scope.
let num_defs = loc_defs.len(); let num_defs = loc_defs.len();
let mut type_defs = Vec::with_capacity(num_defs); let mut pending_type_defs = Vec::with_capacity(num_defs);
let mut value_defs = Vec::with_capacity(num_defs); let mut value_defs = Vec::with_capacity(num_defs);
for loc_def in loc_defs { for loc_def in loc_defs {
match loc_def.value.unroll_def() { match loc_def.value.unroll_def() {
Ok(type_def) => type_defs.push(Loc::at(loc_def.region, type_def)), Ok(type_def) => {
pending_type_defs.push(to_pending_type_def(env, type_def, &mut scope, pattern_type))
}
Err(value_def) => value_defs.push(Loc::at(loc_def.region, value_def)), Err(value_def) => value_defs.push(Loc::at(loc_def.region, value_def)),
} }
} }
// We need to canonicalize all the type defs first.
// Clippy is wrong - we do need the collect, otherwise "env" and "scope" are captured for
// longer than we'd like.
#[allow(clippy::needless_collect)]
let pending_type_defs = type_defs
.into_iter()
.map(|loc_def| to_pending_type_def(env, loc_def.value, &mut scope, pattern_type))
.collect::<Vec<_>>();
if cfg!(debug_assertions) { if cfg!(debug_assertions) {
env.home.register_debug_idents(&env.ident_ids); env.home.register_debug_idents(&env.ident_ids);
} }