language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-09-29 14:54:47 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

Reorganize some things

Browse source
This commit is contained in:
Richard Feldman 2020-03-20 22:38:28 -04:00
parent f86c3f1e7e
commit a286dec4cc
1 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

10
compiler/gen/src/llvm/build.rs
View file

@ -1101,7 +1101,6 @@ fn call_with_args<'a, 'ctx, 'env>(
debug_assert!(args.len() == 3);
let elem_index = args[1].0.into_int_value();
let (elem, elem_layout) = args[2];
let (wrapper_struct, array_data_ptr) = {
// This original wrapper_struct should only stay in scope long enough to clone it.
@ -1126,6 +1125,7 @@ fn call_with_args<'a, 'ctx, 'env>(
let elem_size = env.ptr_int().const_int(elem_bytes, false);
// Calculate the offset at runtime by multiplying the index by the size of an element.
let elem_index = args[1].0.into_int_value();
let offset_bytes = builder.build_int_mul(elem_index, elem_size, "mul_offset");
// We already checked the bounds earlier.
@ -1135,8 +1135,8 @@ fn call_with_args<'a, 'ctx, 'env>(
// Mutate the array in-place.
builder.build_store(elem_ptr, elem);
// Return the wrapper unchanged, since pointer, length and capacity are all unchanged
wrapper_struct.into()
// Return the cloned wrapper
BasicValueEnum::StructValue(wrapper_struct)
}
Symbol::LIST_SET_IN_PLACE => {
let builder = env.builder;
@ -1169,8 +1169,8 @@ fn call_with_args<'a, 'ctx, 'env>(
// Mutate the array in-place.
builder.build_store(elem_ptr, elem);
// Return the wrapper unchanged, since pointer, length and capacity are all unchanged
wrapper_struct.into()
// Return the wrapper unchanged, since pointer and length are unchanged
BasicValueEnum::StructValue(wrapper_struct)
}
_ => {
let fn_val = env