language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-08-03 19:58:18 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

update comments

Browse source
This commit is contained in:
Folkert 2022-10-31 23:56:53 +01:00
parent bb893a70a0
commit a44cd68419
No known key found for this signature in database
GPG key ID: 1F17F6FFD112B97C
1 changed files with 14 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

27
crates/linker/src/pe.rs
View file

@ -251,15 +251,7 @@ fn remove_dummy_dll_import_table_entry(executable: &mut [u8], md: &PeMetadata) {
pub(crate) fn surgery_pe(executable_path: &Path, metadata_path: &Path, roc_app_bytes: &[u8]) {
let md = PeMetadata::read_from_file(metadata_path);
let stack_check_section = Section {
bytes: &___CHKSTK_MS,
kind: SectionKind::Text,
relocations: Default::default(),
app_section_index: object::SectionIndex(0),
};
let mut app_obj_sections = AppSections::from_data(roc_app_bytes);
app_obj_sections.sections.push(stack_check_section);
let app_obj_sections = AppSections::from_data(roc_app_bytes);
let mut symbols = app_obj_sections.roc_symbols;
@ -400,11 +392,10 @@ pub(crate) fn surgery_pe(executable_path: &Path, metadata_path: &Path, roc_app_b
} else if name == "___chkstk_ms" {
// this is a stack probe that is inserted when a function uses more than 2
// pages of stack space. The source of this function is not linked in, so we
// have to get a bit creative: we just jump to a `ret` instruction, so this
// function call becomes a no-op.
// have to do it ourselves. We patch in the bytes as a separate section, and
// here just need to jump to those bytes
// find a the implementation of the stack probe. This relies on the
// ___CHKSTK_MS section being the last text section in the list of sections
// This relies on the ___CHKSTK_MS section being the last text section in the list of sections
let destination = length - ___CHKSTK_MS.len();
let delta =
@ -1132,6 +1123,16 @@ impl<'a> AppSections<'a> {
sections.push(section);
}
// add a fake section that contains code for a stack probe that some app functions need
let stack_check_section = Section {
bytes: &___CHKSTK_MS,
kind: SectionKind::Text,
relocations: Default::default(),
app_section_index: object::SectionIndex(0),
};
sections.push(stack_check_section);
let mut roc_symbols = Vec::new();
let mut other_symbols = Vec::new();