language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-08-03 19:58:18 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Comments and optimizations for builtins

Browse source
This commit is contained in:
Ayaz Hafiz 2022-09-28 11:41:14 -05:00
parent 5d649666fa
commit a5ebd7f477
No known key found for this signature in database
GPG key ID: 0E2A37416A25EF58
1 changed files with 11 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

11
crates/compiler/load_internal/src/work.rs
View file

@ -140,6 +140,11 @@ impl<'a> Dependencies<'a> {
let mut output = MutSet::default();
for dep in dependencies.iter() {
// Do a BFS to check if we have an import cycle; if we do, calculate the cycle and
// report the error. Although the worst case here is that we do a quadratic amount of
// work for all modules added in a batch compilation, in practice, most dependencies
// inserted here have not been seen by [Dependencies] yet, so their import chain is
// size 0.
if self.has_import_dependency(*dep.as_inner(), module_id) {
let mut rev_cycle = self.calculate_reverse_import_path(*dep.as_inner(), module_id);
rev_cycle.push(module_id);
@ -203,8 +208,14 @@ impl<'a> Dependencies<'a> {
}
fn has_import_dependency(&self, module_id: ModuleId, target: ModuleId) -> bool {
if module_id.is_builtin() {
return false;
}
let mut stack = vec![module_id];
while let Some(module) = stack.pop() {
if module.is_builtin() {
continue;
}
if module == target {
return true;
}