language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-09-26 13:29:12 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Crash at runtime rather than panicking when if condition is erroneous

Browse source 
Closes #5318
This commit is contained in:
Ayaz Hafiz 2023-05-01 15:48:05 -05:00
parent cdf8677dfb
commit a9975b1f7f
No known key found for this signature in database
GPG key ID: 0E2A37416A25EF58
4 changed files with 31 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

16
crates/compiler/mono/src/ir.rs
View file

@ -6613,12 +6613,16 @@ pub fn from_can<'a>(
branches,
final_else,
} => {
let ret_layout = layout_cache
.from_var(env.arena, branch_var, env.subs)
.expect("invalid ret_layout");
let cond_layout = layout_cache
.from_var(env.arena, cond_var, env.subs)
.expect("invalid cond_layout");
let ret_layout = return_on_layout_error!(
env,
layout_cache.from_var(env.arena, branch_var, env.subs),
"invalid return type in if expression"
);
let cond_layout = return_on_layout_error!(
env,
layout_cache.from_var(env.arena, cond_var, env.subs),
"invalid condition type in if expression"
);
let mut stmt = from_can(env, branch_var, final_else.value, procs, layout_cache);