language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-09-27 13:59:08 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Use two caches instead of a unified one for obligation checking

Browse source
This commit is contained in:
Ayaz Hafiz 2022-05-20 17:39:09 -04:00
parent a4c122d5db
commit ababfa4129
No known key found for this signature in database
GPG key ID: 0E2A37416A25EF58
5 changed files with 269 additions and 180 deletions
Download patch file Download diff file Expand all files Collapse all files

20
compiler/solve/src/solve.rs
View file

@ -97,6 +97,12 @@ pub enum TypeError {
ability: Symbol,
member: Symbol,
},
DominatedDerive {
opaque: Symbol,
ability: Symbol,
derive_region: Region,
impl_region: Region,
},
}
use roc_types::types::Alias;
@ -1526,9 +1532,10 @@ fn check_ability_specialization(
subs.commit_snapshot(snapshot);
introduce(subs, rank, pools, &vars);
let specialization_region = symbol_loc_var.region;
let specialization = MemberSpecialization {
symbol,
region: symbol_loc_var.region,
region: specialization_region,
};
abilities_store.register_specialization_for_type(
root_symbol,
@ -1541,10 +1548,13 @@ fn check_ability_specialization(
deferred_obligations
.add(must_implement_ability, AbilityImplError::IncompleteAbility);
// This specialization dominates any derives that might be present.
deferred_obligations.dominate(DeriveKey {
opaque,
ability: parent_ability,
});
deferred_obligations.dominate(
DeriveKey {
opaque,
ability: parent_ability,
},
specialization_region,
);
}
Some(Obligated::Adhoc(var)) => {
// This is a specialization of a structural type - never allowed.