language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-09-26 13:29:12 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Add undefined rc procs for LinkedData too

Browse source
This commit is contained in:
Agus Zubiaga 2023-10-08 00:53:04 -03:00 • committed by Folkert
parent 99369dec85
commit ad127eb395
No known key found for this signature in database
GPG key ID: 1F17F6FFD112B97C
1 changed files with 30 additions and 24 deletions
Download patch file Download diff file Expand all files Collapse all files

54
crates/compiler/gen_dev/src/object_builder.rs
View file

@ -920,6 +920,8 @@ fn build_proc<'a, B: Backend<'a>>(
} }
} }
Relocation::LinkedData { offset, name } => { Relocation::LinkedData { offset, name } => {
add_undefined_rc_proc(output, name, &rc_proc_names);
if let Some(sym_id) = output.symbol_id(name.as_bytes()) { if let Some(sym_id) = output.symbol_id(name.as_bytes()) {
if cfg!(all(target_arch = "aarch64", target_os = "linux")) { if cfg!(all(target_arch = "aarch64", target_os = "linux")) {
// 700: 90000001 adrp x1, 0x0 <std.builtin.default_panic> // 700: 90000001 adrp x1, 0x0 <std.builtin.default_panic>
@ -1005,30 +1007,7 @@ fn build_proc<'a, B: Backend<'a>>(
output.add_symbol(builtin_symbol); output.add_symbol(builtin_symbol);
} }
// If the symbol is an undefined reference counting procedure, we need to add it here. add_undefined_rc_proc(output, name, &rc_proc_names);
if output.symbol_id(name.as_bytes()).is_none() {
for (sym, rc_name) in rc_proc_names.iter() {
if name == rc_name {
let section_id = output.add_section(
output.segment_name(StandardSegment::Text).to_vec(),
format!(".text.{:x}", sym.as_u64()).as_bytes().to_vec(),
SectionKind::Text,
);
let rc_symbol = Symbol {
name: name.as_bytes().to_vec(),
value: 0,
size: 0,
kind: SymbolKind::Text,
scope: SymbolScope::Linkage,
weak: false,
section: SymbolSection::Section(section_id),
flags: SymbolFlags::None,
};
output.add_symbol(rc_symbol);
}
}
}
if let Some(sym_id) = output.symbol_id(name.as_bytes()) { if let Some(sym_id) = output.symbol_id(name.as_bytes()) {
create_relocation(target_info, sym_id, offset + proc_offset) create_relocation(target_info, sym_id, offset + proc_offset)
@ -1041,3 +1020,30 @@ fn build_proc<'a, B: Backend<'a>>(
relocations.push((section_id, elfreloc)); relocations.push((section_id, elfreloc));
} }
} }
fn add_undefined_rc_proc(output: &mut Object<'_>, name: &String, rc_proc_names: &Vec<'_, (symbol::Symbol, String)>) {
// If the symbol is an undefined reference counting procedure, we need to add it here.
if output.symbol_id(name.as_bytes()).is_none() {
for (sym, rc_name) in rc_proc_names.iter() {
if name == rc_name {
let section_id = output.add_section(
output.segment_name(StandardSegment::Text).to_vec(),
format!(".text.{:x}", sym.as_u64()).as_bytes().to_vec(),
SectionKind::Text,
);
let rc_symbol = Symbol {
name: name.as_bytes().to_vec(),
value: 0,
size: 0,
kind: SymbolKind::Text,
scope: SymbolScope::Linkage,
weak: false,
section: SymbolSection::Section(section_id),
flags: SymbolFlags::None,
};
output.add_symbol(rc_symbol);
}
}
}
}