language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-10-01 07:41:12 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Disallow abilities on toplevel of scope

Browse source
This commit is contained in:
Ayaz Hafiz 2022-05-09 09:45:02 -04:00
parent 9515f60479
commit b0734c3d80
No known key found for this signature in database
GPG key ID: 0E2A37416A25EF58
4 changed files with 63 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

18
compiler/can/src/def.rs
View file

@ -505,6 +505,7 @@ pub(crate) fn canonicalize_defs<'a>(
output,
scope,
var_store,
pattern_type,
&mut aliases,
&abilities_in_scope,
);
@ -981,12 +982,13 @@ fn canonicalize_pending_value_def<'a>(
mut output: Output,
scope: &mut Scope,
var_store: &mut VarStore,
pattern_type: PatternType,
aliases: &mut VecMap<Symbol, Alias>,
abilities_in_scope: &[Symbol],
) -> DefOutput {
use PendingValueDef::*;
match pending_def {
let output = match pending_def {
AnnotationOnly(_, loc_can_pattern, loc_ann) => {
// Make types for the body expr, even if we won't end up having a body.
let expr_var = var_store.fresh();
@ -1129,7 +1131,21 @@ fn canonicalize_pending_value_def<'a>(
None,
)
}
};
// Disallow ability specializations that aren't on the toplevel (note: we might loosen this
// restriction later on).
if pattern_type != PatternType::TopLevelDef {
if let Loc {
value: Pattern::AbilityMemberSpecialization { specializes, .. },
region,
} = output.def.loc_pattern
{
env.problem(Problem::NestedSpecialization(specializes, region));
}
}
output
}
// TODO trim down these arguments!