language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-10-03 08:34:33 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Handle Roc's return by pointer flowing into a C ABI return by pointer

Browse source
This commit is contained in:
Ayaz Hafiz 2022-08-29 08:56:22 -05:00
parent 6cada1ab6e
commit b44d68aac5
No known key found for this signature in database
GPG key ID: 0E2A37416A25EF58
1 changed files with 14 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

14
crates/compiler/gen_llvm/src/llvm/build.rs
View file

@ -3811,8 +3811,20 @@ fn expose_function_to_host_help_c_abi_v2<'a, 'ctx, 'env>(
}, },
CCReturn::ByPointer => { CCReturn::ByPointer => {
let out_ptr = c_function.get_nth_param(0).unwrap().into_pointer_value(); let out_ptr = c_function.get_nth_param(0).unwrap().into_pointer_value();
match roc_return {
RocReturn::Return => {
env.builder.build_store(out_ptr, value); env.builder.build_store(out_ptr, value);
}
RocReturn::ByPointer => {
// TODO: ideally, in this case, we should pass the C return pointer directly
// into the call_roc_function rather than forcing an extra alloca, load, and
// store!
let value = env
.builder
.build_load(value.into_pointer_value(), "load_roc_result");
env.builder.build_store(out_ptr, value);
}
}
env.builder.build_return(None); env.builder.build_return(None);
} }
CCReturn::Void => { CCReturn::Void => {