clippy+fmt

crates/cli/tests/cli_run.rs

@@ -118,7 +118,12 @@ mod cli_run {
             panic!("\n___________\nThe roc command:\n\n  {}\n\nhad unexpected stderr:\n\n  {}\n___________\n", compile_out.cmd_str, stderr);
         }
 
-        assert!(compile_out.status.success(), "\n___________\nRoc command failed with status {:?}:\n\n  {:?}\n___________\n", compile_out.status, compile_out);
+        assert!(
+            compile_out.status.success(),
+            "\n___________\nRoc command failed with status {:?}:\n\n  {:?}\n___________\n",
+            compile_out.status,
+            compile_out
+        );
 
         compile_out
     }

crates/compiler/builtins/build.rs

@@ -222,14 +222,14 @@ fn run_command(mut command: Command, flaky_fail_counter: usize) {
                     } else {
                         run_command(command, flaky_fail_counter + 1)
                     }
-                } else {
+                } else if error_str
-                    if error_str.contains("lld-link: error: failed to write the output file: Permission denied") {
+                    .contains("lld-link: error: failed to write the output file: Permission denied")
-                        panic!("{} failed with:\n\n  {}\n\nWorkaround:\n\n  Re-run the cargo command that triggered this build.", command_str, error_str);
+                {
+                    panic!("{} failed with:\n\n  {}\n\nWorkaround:\n\n  Re-run the cargo command that triggered this build.\n\n", command_str, error_str);
                 } else {
                     panic!("{} failed with:\n\n  {}\n", command_str, error_str);
                 }
             }
-            }
         },
         Err(reason) => panic!("{} failed: {}", command_str, reason),
     }

crates/compiler/fmt/src/lib.rs

@@ -18,7 +18,6 @@ const NEWLINE: &str = "\r\n";
 #[cfg(not(windows))]
 const NEWLINE: &str = "\n";
 
-
 #[derive(Debug)]
 pub struct Ast<'a> {
     pub module: Module<'a>,

crates/compiler/load/build.rs

@@ -4,6 +4,7 @@ use std::path::{Path, PathBuf};
 use bumpalo::Bump;
 use roc_module::symbol::ModuleId;
 
+#[cfg(not(windows))]
 const ROC_SKIP_SUBS_CACHE: &str = "ROC_SKIP_SUBS_CACHE";
 
 const SKIP_SUBS_CACHE: bool = {

crates/utils/src/lib.rs

@@ -3,7 +3,7 @@ use snafu::OptionExt;
 use std::{
     collections::HashMap,
     env::{self, VarError},
-    path::PathBuf,
+    path::{Path, PathBuf},
     process::Command,
     slice::SliceIndex,
 };
@@ -107,7 +107,6 @@ pub fn get_lib_path() -> Option<PathBuf> {
     let exe_relative_str_path_opt = std::env::current_exe().ok();
 
     if let Some(exe_relative_str_path) = exe_relative_str_path_opt {
-
         #[cfg(windows)]
         let exe_relative_str_path = strip_windows_prefix(&exe_relative_str_path);
 
@@ -136,8 +135,7 @@ pub fn get_lib_path() -> Option<PathBuf> {
 /// Such a path does not works as an argument to `zig` and other command line tools,
 /// and there seems to be no good way to strip it. So we resort to some string manipulation.
 #[cfg(windows)]
-pub fn strip_windows_prefix(path_buf: &PathBuf) -> std::path::PathBuf {
+pub fn strip_windows_prefix(path_buf: &Path) -> std::path::PathBuf {
-    
     let path_str = path_buf.display().to_string();
 
     std::path::Path::new(path_str.trim_start_matches(r"\\?\")).to_path_buf()