language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-09-29 14:54:47 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

Use inner list len for end condition of loop through inner list elements

Browse source
This commit is contained in:
Chad Stearns 2020-08-02 19:04:26 -04:00
parent 3011bfa7be
commit b9673b68fe
1 changed files with 6 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

9
compiler/gen/src/llvm/build.rs
View file

@ -1684,7 +1684,7 @@ fn list_join<'a, 'ctx, 'env>(
builder.build_store(index_alloca, next_index); builder.build_store(index_alloca, next_index);
// The pointer to the list in the outer list (the list of lists) // The pointer to the list in the outer list (the list of lists)
let inner_list_ptr = { let (inner_list_len, inner_list_ptr) = {
let wrapper_ptr = unsafe { let wrapper_ptr = unsafe {
builder.build_in_bounds_gep(outer_list_ptr, &[curr_index], "load_index") builder.build_in_bounds_gep(outer_list_ptr, &[curr_index], "load_index")
}; };
@ -1693,7 +1693,10 @@ fn list_join<'a, 'ctx, 'env>(
.into_struct_value(); .into_struct_value();
let elem_ptr_type = get_ptr_type(&elem_type, AddressSpace::Generic); let elem_ptr_type = get_ptr_type(&elem_type, AddressSpace::Generic);
load_list_ptr(builder, wrapper, elem_ptr_type) (
load_list_len(builder, wrapper),
load_list_ptr(builder, wrapper, elem_ptr_type),
)
}; };
// Inner Loop // Inner Loop
@ -1744,7 +1747,7 @@ fn list_join<'a, 'ctx, 'env>(
let outer_loop_end_cond = builder.build_int_compare( let outer_loop_end_cond = builder.build_int_compare(
IntPredicate::ULT, IntPredicate::ULT,
next_index, next_index,
outer_list_len, inner_list_len,
"loopcond", "loopcond",
); );