language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-08-03 19:58:18 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Several fixes found in fuzzing

Browse source
This commit is contained in:
Joshua Warner 2024-11-29 18:52:54 -08:00
parent e9caada3f1
commit b9862b47dc
No known key found for this signature in database
GPG key ID: 89AD497003F93FDD
49 changed files with 1060 additions and 523 deletions
Download patch file Download diff file Expand all files Collapse all files

2
crates/compiler/test_syntax/tests/snapshots/fail/if_guard_without_condition.expr.result-ast
View file

@ -1 +1 @@
Expr(When(IfGuard(Start(@28), @27), @0), @0)
Expr(When(IfGuard(Start(@27), @27), @0), @0)

1
crates/compiler/test_syntax/tests/snapshots/fail/ifbang_eqeq.expr.result-ast Normal file
View file

@ -0,0 +1 @@
Expr(If(Condition(Start(@2), @2), @0), @0)

1
crates/compiler/test_syntax/tests/snapshots/fail/ifbang_eqeq.expr.roc Normal file
View file

@ -0,0 +1 @@
if!==9

2
crates/compiler/test_syntax/tests/snapshots/pass/annotated_tag_destructure.expr.formatted.roc
View file

@ -1,4 +1,4 @@
UserId x : [UserId I64]
(UserId x) = UserId 42
UserId x = UserId 42
x

4
crates/compiler/test_syntax/tests/snapshots/pass/binop_closure_apply.expr.formatted.roc Normal file
View file

@ -0,0 +1,4 @@
d
+
(\w -> x)
x

41
crates/compiler/test_syntax/tests/snapshots/pass/binop_closure_apply.expr.result-ast Normal file
View file

@ -0,0 +1,41 @@
BinOps(
[
(
@0-1 Var {
module_name: "",
ident: "d",
},
@1-2 Plus,
),
],
@4-12 Apply(
@4-9 SpaceBefore(
Closure(
[
@5-6 Identifier {
ident: "w",
},
],
@8-9 Var {
module_name: "",
ident: "x",
},
),
[
Newline,
],
),
[
@11-12 SpaceBefore(
Var {
module_name: "",
ident: "x",
},
[
Newline,
],
),
],
Space,
),
)

3
crates/compiler/test_syntax/tests/snapshots/pass/binop_closure_apply.expr.roc Normal file
View file

@ -0,0 +1,3 @@
d+
\w->x
x

7
crates/compiler/test_syntax/tests/snapshots/pass/binops_comment_indent_change.expr.formatted.roc Normal file
View file

@ -0,0 +1,7 @@
r
^
(
-f
#
-P
)

42
crates/compiler/test_syntax/tests/snapshots/pass/binops_comment_indent_change.expr.result-ast Normal file
View file

@ -0,0 +1,42 @@
BinOps(
[
(
@0-1 Var {
module_name: "",
ident: "r",
},
@1-2 Caret,
),
],
@3-11 Apply(
@3-5 SpaceAfter(
SpaceBefore(
UnaryOp(
@4-5 Var {
module_name: "",
ident: "f",
},
@3-4 Negate,
),
[
Newline,
],
),
[
Newline,
LineComment(
"",
),
],
),
[
@9-11 UnaryOp(
@10-11 Tag(
"P",
),
@9-10 Negate,
),
],
Space,
),
)

4
crates/compiler/test_syntax/tests/snapshots/pass/binops_comment_indent_change.expr.roc Normal file
View file

@ -0,0 +1,4 @@
r^
-f
#
-P

3
crates/compiler/test_syntax/tests/snapshots/pass/closure_pat_reccord_comment.expr.formatted.roc Normal file
View file

@ -0,0 +1,3 @@
\{ i, #
e }
-> a

25
crates/compiler/test_syntax/tests/snapshots/pass/closure_pat_reccord_comment.expr.result-ast Normal file
View file

@ -0,0 +1,25 @@
Closure(
[
@1-8 RecordDestructure(
[
@2-3 SpaceAfter(
Identifier {
ident: "i",
},
[
LineComment(
"",
),
],
),
@6-7 Identifier {
ident: "e",
},
],
),
],
@10-11 Var {
module_name: "",
ident: "a",
},
)

2
crates/compiler/test_syntax/tests/snapshots/pass/closure_pat_reccord_comment.expr.roc Normal file
View file

@ -0,0 +1,2 @@
\{i#
,e}->a

8
crates/compiler/test_syntax/tests/snapshots/pass/comment_before_comma_in_tuple_type_with_func.expr.formatted.roc Normal file
View file

@ -0,0 +1,8 @@
1 : (
M,
b # ,
,
h
-> g,
)e
h

74
crates/compiler/test_syntax/tests/snapshots/pass/comment_before_comma_in_tuple_type_with_func.expr.result-ast Normal file
View file

@ -0,0 +1,74 @@
SpaceAfter(
Defs(
Defs {
tags: [
EitherIndex(2147483648),
],
regions: [
@0-16,
],
space_before: [
Slice<roc_parse::ast::CommentOrNewline> { start: 0, length: 0 },
],
space_after: [
Slice<roc_parse::ast::CommentOrNewline> { start: 0, length: 0 },
],
spaces: [],
type_defs: [],
value_defs: [
Annotation(
@0-1 NumLiteral(
"1",
),
@2-16 Tuple {
elems: [
@3-14 Function(
[
@3-4 Apply(
"",
"M",
[],
),
@5-6 SpaceAfter(
BoundVariable(
"b",
),
[
LineComment(
",",
),
],
),
@10-11 BoundVariable(
"h",
),
],
Pure,
@13-14 BoundVariable(
"g",
),
),
],
ext: Some(
@15-16 BoundVariable(
"e",
),
),
},
),
],
},
@17-18 SpaceBefore(
Var {
module_name: "",
ident: "h",
},
[
Newline,
],
),
),
[
Newline,
],
)

3
crates/compiler/test_syntax/tests/snapshots/pass/comment_before_comma_in_tuple_type_with_func.expr.roc Normal file
View file

@ -0,0 +1,3 @@
1:(M,b#,
,h->g)e
h

6
crates/compiler/test_syntax/tests/snapshots/pass/dbg_stmt_in_parens.expr.formatted.roc Normal file
View file

@ -0,0 +1,6 @@
(
dbg
D
q
h
)

27
crates/compiler/test_syntax/tests/snapshots/pass/dbg_stmt_in_parens.expr.result-ast Normal file
View file

@ -0,0 +1,27 @@
ParensAround(
DbgStmt {
first: @5-6 Tag(
"D",
),
extra_args: [
@8-9 SpaceBefore(
Var {
module_name: "",
ident: "q",
},
[
Newline,
],
),
],
continuation: @10-11 SpaceBefore(
Var {
module_name: "",
ident: "h",
},
[
Newline,
],
),
},
)

3
crates/compiler/test_syntax/tests/snapshots/pass/dbg_stmt_in_parens.expr.roc Normal file
View file

@ -0,0 +1,3 @@
(dbg D
q
h)

2
crates/compiler/test_syntax/tests/snapshots/pass/destructure_tag_assignment.expr.formatted.roc
View file

@ -1,2 +1,2 @@
(Email str) = Email "blah@example.com"
Email str = Email "blah@example.com"
str

53
crates/compiler/test_syntax/tests/snapshots/pass/i_over_not_g.expr.result-ast
View file

@ -1,28 +1,33 @@
BinOps(
[
(
@0-1 Var {
module_name: "",
ident: "i",
},
@1-2 Slash,
),
],
@3-7 SpaceBefore(
UnaryOp(
@6-7 SpaceBefore(
Var {
module_name: "",
ident: "g",
},
[
Newline,
],
),
@3-4 Not,
),
SpaceAfter(
BinOps(
[
Newline,
(
@0-1 Var {
module_name: "",
ident: "i",
},
@1-2 Slash,
),
],
@4-8 SpaceBefore(
UnaryOp(
@7-8 SpaceBefore(
Var {
module_name: "",
ident: "g",
},
[
Newline,
],
),
@4-5 Not,
),
[
Newline,
],
),
),
[
Newline,
],
)

4
crates/compiler/test_syntax/tests/snapshots/pass/i_over_not_g.expr.roc
View file

@ -1,3 +1,3 @@
i/
!
g
!
g

6
crates/compiler/test_syntax/tests/snapshots/pass/if_newline_then_negate_else_recordupdater.expr.formatted.roc Normal file
View file

@ -0,0 +1,6 @@
if
h
then
!f #
else
&m

43
crates/compiler/test_syntax/tests/snapshots/pass/if_newline_then_negate_else_recordupdater.expr.result-ast Normal file
View file

@ -0,0 +1,43 @@
SpaceAfter(
If {
if_thens: [
(
@3-4 SpaceBefore(
SpaceAfter(
Var {
module_name: "",
ident: "h",
},
[
Newline,
],
),
[
Newline,
],
),
@9-11 SpaceAfter(
UnaryOp(
@10-11 Var {
module_name: "",
ident: "f",
},
@9-10 Not,
),
[
LineComment(
"",
),
],
),
),
],
final_else: @17-19 RecordUpdater(
"m",
),
indented_else: false,
},
[
Newline,
],
)

4
crates/compiler/test_syntax/tests/snapshots/pass/if_newline_then_negate_else_recordupdater.expr.roc Normal file
View file

@ -0,0 +1,4 @@
if
h
then!f#
else&m

2
crates/compiler/test_syntax/tests/snapshots/pass/multiline_apply_equals_multiline_apply.expr.formatted.roc
View file

@ -1,3 +1,3 @@
(MT q) = g
MT q = g
q
dbgT

5
crates/compiler/test_syntax/tests/snapshots/pass/multiline_str_crazyness.expr.formatted.roc Normal file
View file

@ -0,0 +1,5 @@
"""
"""
"$(i
"""
""")"

32
crates/compiler/test_syntax/tests/snapshots/pass/multiline_str_crazyness.expr.result-ast Normal file
View file

@ -0,0 +1,32 @@
Apply(
@0-6 Str(
Block(
[],
),
),
[
@6-18 Str(
Line(
[
Interpolated(
@9-16 Apply(
@9-10 Var {
module_name: "",
ident: "i",
},
[
@10-16 Str(
Block(
[],
),
),
],
Space,
),
),
],
),
),
],
Space,
)

1
crates/compiler/test_syntax/tests/snapshots/pass/multiline_str_crazyness.expr.roc Normal file
View file

@ -0,0 +1 @@
"""""""$(i"""""")"

2
crates/compiler/test_syntax/tests/snapshots/pass/negative_number_in_pattern.expr.formatted.roc Normal file
View file

@ -0,0 +1,2 @@
N -0 T : A
zT

52
crates/compiler/test_syntax/tests/snapshots/pass/negative_number_in_pattern.expr.result-ast Normal file
View file

@ -0,0 +1,52 @@
SpaceAfter(
Defs(
Defs {
tags: [
EitherIndex(0),
],
regions: [
@0-8,
],
space_before: [
Slice<roc_parse::ast::CommentOrNewline> { start: 0, length: 0 },
],
space_after: [
Slice<roc_parse::ast::CommentOrNewline> { start: 0, length: 0 },
],
spaces: [],
type_defs: [
Alias {
header: TypeHeader {
name: @0-1 "N",
vars: [
@2-4 NumLiteral(
"-0",
),
@5-6 Tag(
"T",
),
],
},
ann: @7-8 Apply(
"",
"A",
[],
),
},
],
value_defs: [],
},
@9-11 SpaceBefore(
Var {
module_name: "",
ident: "zT",
},
[
Newline,
],
),
),
[
Newline,
],
)

2
crates/compiler/test_syntax/tests/snapshots/pass/negative_number_in_pattern.expr.roc Normal file
View file

@ -0,0 +1,2 @@
N -0 T:A
zT

2
crates/compiler/test_syntax/tests/snapshots/pass/opaque_destructure_first_item_in_body.expr.formatted.roc
View file

@ -1,2 +1,2 @@
(@Thunk it) = id (@A {})
@Thunk it = id (@A {})
it {}

2
crates/compiler/test_syntax/tests/snapshots/pass/pat_space_after_comma.expr.formatted.roc Normal file
View file

@ -0,0 +1,2 @@
{ i, p } = 5
Q

53
crates/compiler/test_syntax/tests/snapshots/pass/pat_space_after_comma.expr.result-ast Normal file
View file

@ -0,0 +1,53 @@
SpaceAfter(
Defs(
Defs {
tags: [
EitherIndex(2147483648),
],
regions: [
@0-8,
],
space_before: [
Slice<roc_parse::ast::CommentOrNewline> { start: 0, length: 0 },
],
space_after: [
Slice<roc_parse::ast::CommentOrNewline> { start: 0, length: 0 },
],
spaces: [],
type_defs: [],
value_defs: [
Body(
@0-6 RecordDestructure(
[
@1-3 SpaceAfter(
Identifier {
ident: "i",
},
[
Newline,
],
),
@4-5 Identifier {
ident: "p",
},
],
),
@7-8 Num(
"5",
),
),
],
},
@9-10 SpaceBefore(
Tag(
"Q",
),
[
Newline,
],
),
),
[
Newline,
],
)

3
crates/compiler/test_syntax/tests/snapshots/pass/pat_space_after_comma.expr.roc Normal file
View file

@ -0,0 +1,3 @@
{i
,p}=5
Q

4
crates/compiler/test_syntax/tests/snapshots/pass/record_with_lots_of_newlines.expr.formatted.roc Normal file
View file

@ -0,0 +1,4 @@
{
t, #
}

25
crates/compiler/test_syntax/tests/snapshots/pass/record_with_lots_of_newlines.expr.result-ast Normal file
View file

@ -0,0 +1,25 @@
SpaceAfter(
Record(
Collection {
items: [
@1-4 SpaceAfter(
LabelOnly(
@1-2 "t",
),
[
LineComment(
"",
),
],
),
],
final_comments: [
Newline,
Newline,
],
},
),
[
Newline,
],
)

4
crates/compiler/test_syntax/tests/snapshots/pass/record_with_lots_of_newlines.expr.roc Normal file
View file

@ -0,0 +1,4 @@
{t#
,
}

2
crates/compiler/test_syntax/tests/snapshots/pass/tag_destructure_bang.expr.formatted.roc
View file

@ -1,3 +1,3 @@
(Config launchTheNukes! code) = cfg
Config launchTheNukes! code = cfg
launchTheNukes! code

2
crates/compiler/test_syntax/tests/snapshots/pass/tag_destructure_bang_no_space.expr.formatted.roc
View file

@ -1,3 +1,3 @@
(Config launchTheNukes! code) = cfg
Config launchTheNukes! code = cfg
launchTheNukes! code

8
crates/compiler/test_syntax/tests/snapshots/pass/underscore_in_assignment_pattern.expr.formatted.roc
View file

@ -1,7 +1,7 @@
(Pair x _) = Pair 0 1
(Pair _ y) = Pair 0 1
(Pair _ _) = Pair 0 1
Pair x _ = Pair 0 1
Pair _ y = Pair 0 1
Pair _ _ = Pair 0 1
_ = Pair 0 1
(Pair (Pair x _) (Pair _ y)) = Pair (Pair 0 1) (Pair 2 3)
Pair (Pair x _) (Pair _ y) = Pair (Pair 0 1) (Pair 2 3)
0

11
crates/compiler/test_syntax/tests/test_snapshots.rs
View file

@ -207,6 +207,7 @@ mod test_snapshots {
fail/if_missing_else.expr,
fail/if_outdented_else_branch.expr,
fail/if_outdented_then.expr,
fail/ifbang_eqeq.expr,
fail/import_with_lowercase_alias.moduledefs,
fail/imports_missing_comma.header,
fail/inline_hastype.expr,
@ -317,6 +318,8 @@ mod test_snapshots {
pass/basic_var.expr,
pass/binop_apply_complex.expr,
pass/binop_assign_defs_nested.expr,
pass/binop_closure_apply.expr,
pass/binops_comment_indent_change.expr,
pass/block_string_ann.expr,
pass/body_block_string_apply_string.expr,
pass/body_with_unneeded_parens.expr,
@ -324,6 +327,7 @@ mod test_snapshots {
pass/call_bang_no_space.expr,
pass/closure_in_apply_in_binop.expr,
pass/closure_in_binop_with_spaces.expr,
pass/closure_pat_reccord_comment.expr,
pass/closure_with_underscores.expr,
pass/comma_prefixed_indented_record.expr,
pass/comment_after_annotation.expr,
@ -331,6 +335,7 @@ mod test_snapshots {
pass/comment_after_expr_in_parens.expr,
pass/comment_after_op.expr,
pass/comment_before_colon_def.expr,
pass/comment_before_comma_in_tuple_type_with_func.expr,
pass/comment_before_equals_def.expr,
pass/comment_before_op.expr,
pass/comment_before_pat_in_parens.expr,
@ -353,6 +358,7 @@ mod test_snapshots {
pass/dbg_extra_parens.expr,
pass/dbg_newline_apply.expr,
pass/dbg_stmt.expr,
pass/dbg_stmt_in_parens.expr,
pass/dbg_stmt_multiline.expr,
pass/dbg_stmt_two_exprs.expr,
pass/def_bang.expr,
@ -396,6 +402,7 @@ mod test_snapshots {
pass/highest_int.expr,
pass/i_over_not_g.expr,
pass/if_def.expr,
pass/if_newline_then_negate_else_recordupdater.expr,
pass/implements_newlines_comments.expr,
pass/import.moduledefs,
pass/import_from_package.moduledefs,
@ -447,6 +454,7 @@ mod test_snapshots {
pass/multiline_apply_equals_multiline_apply.expr,
pass/multiline_backpassing.expr,
pass/multiline_binop_when_with_comments.expr,
pass/multiline_str_crazyness.expr,
pass/multiline_str_in_pat.expr,
pass/multiline_string.expr,
pass/multiline_string_in_apply.expr,
@ -464,6 +472,7 @@ mod test_snapshots {
pass/negative_float.expr,
pass/negative_in_apply_def.expr,
pass/negative_int.expr,
pass/negative_number_in_pattern.expr,
pass/negative_single_quote.expr,
pass/nested_def_annotation.moduledefs,
pass/nested_if.expr,
@ -530,6 +539,7 @@ mod test_snapshots {
pass/parenthetical_var.expr,
pass/parse_alias.expr,
pass/parse_as_ann.expr,
pass/pat_space_after_comma.expr,
pass/pattern_as.expr,
pass/pattern_as_list_rest.expr,
pass/pattern_as_spaces.expr,
@ -560,6 +570,7 @@ mod test_snapshots {
pass/record_updater_literal_apply.expr,
pass/record_updater_var_apply.expr,
pass/record_with_if.expr,
pass/record_with_lots_of_newlines.expr,
pass/requires_type.header,
pass/return_apply_newline.expr,
pass/return_field_access_in_parens.expr,