language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-10-02 08:11:12 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Add some debug-assertions regarding what we know about specializations

Browse source
This commit is contained in:
Ayaz Hafiz 2022-05-09 10:13:54 -04:00
parent b2e045bf9a
commit bdccda6cfb
No known key found for this signature in database
GPG key ID: 0E2A37416A25EF58
1 changed files with 11 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

12
compiler/can/src/def.rs
View file

@ -783,7 +783,7 @@ pub(crate) fn sort_can_defs(
// recursive relations between any 2 definitions. // recursive relations between any 2 definitions.
let sccs = def_ordering.references.strongly_connected_components_all(); let sccs = def_ordering.references.strongly_connected_components_all();
let mut declarations = Vec::new(); let mut declarations = Vec::with_capacity(defs.len());
for group in sccs.groups() { for group in sccs.groups() {
if group.count_ones() == 1 { if group.count_ones() == 1 {
@ -791,6 +791,10 @@ pub(crate) fn sort_can_defs(
let index = group.iter_ones().next().unwrap(); let index = group.iter_ones().next().unwrap();
let def = take_def!(index); let def = take_def!(index);
let is_specialization = matches!(
def.loc_pattern.value,
Pattern::AbilityMemberSpecialization { .. }
);
let declaration = if def_ordering.direct_references.get_row_col(index, index) { let declaration = if def_ordering.direct_references.get_row_col(index, index) {
// a definition like `x = x + 1`, which is invalid in roc // a definition like `x = x + 1`, which is invalid in roc
@ -803,6 +807,8 @@ pub(crate) fn sort_can_defs(
Declaration::InvalidCycle(entries) Declaration::InvalidCycle(entries)
} else if def_ordering.references.get_row_col(index, index) { } else if def_ordering.references.get_row_col(index, index) {
debug_assert!(!is_specialization, "Self-recursive specializations can only be determined during solving - but it was determined for {:?} now, that's a bug!", def);
// this function calls itself, and must be typechecked as a recursive def // this function calls itself, and must be typechecked as a recursive def
Declaration::DeclareRec(vec![mark_def_recursive(def)]) Declaration::DeclareRec(vec![mark_def_recursive(def)])
} else { } else {
@ -826,6 +832,10 @@ pub(crate) fn sort_can_defs(
.direct_references .direct_references
.strongly_connected_components_subset(group); .strongly_connected_components_subset(group);
debug_assert!(
!group.iter_ones().any(|index| matches!((&defs[index]).as_ref().unwrap().loc_pattern.value, Pattern::AbilityMemberSpecialization{..})),
"A specialization is involved in a recursive cycle - this should not be knowable until solving");
let declaration = if direct_sccs.groups().count() == 1 { let declaration = if direct_sccs.groups().count() == 1 {
// all defs are part of the same direct cycle, that is invalid! // all defs are part of the same direct cycle, that is invalid!
let mut entries = Vec::with_capacity(group.count_ones()); let mut entries = Vec::with_capacity(group.count_ones());