language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-09-28 22:34:45 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

special-case properly

Browse source
This commit is contained in:
Folkert 2021-09-08 13:10:44 +02:00
parent 0d1cc3844e
commit bdd07b0968
1 changed files with 45 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

58
compiler/mono/src/ir.rs
View file

@ -3739,35 +3739,67 @@ pub fn with_hole<'a>(
debug_assert_eq!(field_layouts.len(), symbols.len()); debug_assert_eq!(field_layouts.len(), symbols.len());
debug_assert_eq!(fields.len(), symbols.len()); debug_assert_eq!(fields.len(), symbols.len());
let expr = Expr::Struct(symbols); if symbols.len() == 1 {
let mut stmt = Stmt::Let(assigned, expr, record_layout, hole); // TODO we can probably special-case this more, skippiing the generation of
// UpdateExisting
let mut stmt = hole.clone();
let it = field_layouts.iter().zip(symbols.iter()).zip(fields); let what_to_do = &fields[0];
for ((field_layout, symbol), what_to_do) in it {
match what_to_do { match what_to_do {
UpdateExisting(field) => { UpdateExisting(field) => {
substitute_in_exprs(env.arena, &mut stmt, assigned, symbols[0]);
stmt = assign_to_symbol( stmt = assign_to_symbol(
env, env,
procs, procs,
layout_cache, layout_cache,
field.var, field.var,
*field.loc_expr.clone(), *field.loc_expr.clone(),
*symbol, symbols[0],
stmt, stmt,
); );
} }
CopyExisting(index) => { CopyExisting(_) => {
let access_expr = Expr::StructAtIndex { unreachable!(
structure, r"when a record has just one field and is updated, it must update that one field"
index, );
field_layouts,
};
stmt = Stmt::Let(*symbol, access_expr, *field_layout, arena.alloc(stmt));
} }
} }
stmt
} else {
let expr = Expr::Struct(symbols);
let mut stmt = Stmt::Let(assigned, expr, record_layout, hole);
let it = field_layouts.iter().zip(symbols.iter()).zip(fields);
for ((field_layout, symbol), what_to_do) in it {
match what_to_do {
UpdateExisting(field) => {
stmt = assign_to_symbol(
env,
procs,
layout_cache,
field.var,
*field.loc_expr.clone(),
*symbol,
stmt,
);
}
CopyExisting(index) => {
let access_expr = Expr::StructAtIndex {
structure,
index,
field_layouts,
};
stmt =
Stmt::Let(*symbol, access_expr, *field_layout, arena.alloc(stmt));
}
}
}
stmt
} }
stmt
} }
Closure { Closure {