language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-10-03 08:34:33 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Fix List.set tests

Browse source
This commit is contained in:
Richard Feldman 2020-03-08 01:20:43 -05:00
parent 94b41b099f
commit be4abcf173
4 changed files with 22 additions and 29 deletions
Download patch file Download diff file Expand all files Collapse all files

5
compiler/gen/src/crane/convert.rs
View file

@ -27,10 +27,7 @@ pub fn type_from_layout(cfg: TargetFrontendConfig, layout: &Layout<'_>) -> Type
Builtin(builtin) => match builtin { Builtin(builtin) => match builtin {
Int64 => types::I64, Int64 => types::I64,
Float64 => types::F64, Float64 => types::F64,
Str => cfg.pointer_type(), Str | Map(_, _) | Set(_) | List(_) => cfg.pointer_type(),
Map(_, _) => panic!("TODO layout_to_crane_type for Builtin::Map"),
Set(_) => panic!("TODO layout_to_crane_type for Builtin::Set"),
List(_) => panic!("TODO layout_to_crane_type for Builtin::List"),
}, },
} }
} }

7
compiler/gen/src/llvm/build.rs
View file

@ -593,12 +593,7 @@ fn call_with_args<'a, 'ctx, 'env>(
builder.build_load(elem_ptr, "List.get") builder.build_load(elem_ptr, "List.get")
} }
Symbol::LIST_SET => { Symbol::LIST_SET /* TODO clone first for LIST_SET! */ | Symbol::LIST_SET_IN_PLACE => {
debug_assert!(args.len() == 3);
panic!("TODO List.set with clone");
}
Symbol::LIST_SET_IN_PLACE => {
debug_assert!(args.len() == 3); debug_assert!(args.len() == 3);
let list_ptr = args[0].into_pointer_value(); let list_ptr = args[0].into_pointer_value();

4
compiler/gen/src/llvm/convert.rs
View file

@ -56,7 +56,9 @@ pub fn basic_type_from_layout<'ctx>(
.as_basic_type_enum(), .as_basic_type_enum(),
Map(_, _) => panic!("TODO layout_to_basic_type for Builtin::Map"), Map(_, _) => panic!("TODO layout_to_basic_type for Builtin::Map"),
Set(_) => panic!("TODO layout_to_basic_type for Builtin::Set"), Set(_) => panic!("TODO layout_to_basic_type for Builtin::Set"),
List(_) => panic!("TODO layout_to_basic_type for Builtin::List"), List(elem_layout) => basic_type_from_layout(context, elem_layout)
.ptr_type(AddressSpace::Generic)
.as_basic_type_enum(),
}, },
} }
} }

35
compiler/gen/tests/test_gen.rs
View file

@ -444,7 +444,6 @@ mod test_gen {
{ {
assert_llvm_evals_to!($src, $expected, $ty, (|val| val)); assert_llvm_evals_to!($src, $expected, $ty, (|val| val));
} }
{ {
assert_opt_evals_to!($src, $expected, $ty, (|val| val)); assert_opt_evals_to!($src, $expected, $ty, (|val| val));
} }
@ -488,25 +487,25 @@ mod test_gen {
assert_evals_to!("List.getUnsafe [ 12, 9, 6, 3 ] 1", 9, i64); assert_evals_to!("List.getUnsafe [ 12, 9, 6, 3 ] 1", 9, i64);
} }
// #[test] #[test]
// fn set_unique_int_list() { fn set_unique_int_list() {
// assert_evals_to!("List.getUnsafe (List.set [ 12, 9, 7, 3 ] 1 42) 1", 42, i64); assert_evals_to!("List.getUnsafe (List.set [ 12, 9, 7, 3 ] 1 42) 1", 42, i64);
// } }
// #[test] #[test]
// fn set_shared_int_list() { fn set_shared_int_list() {
// assert_evals_to!( assert_evals_to!(
// indoc!( indoc!(
// r#" r#"
// shared = [ 2, 4 ] shared = [ 2, 4 ]
// List.getUnsafe shared 1 List.getUnsafe shared 1
// "# "#
// ), ),
// 4, 4,
// i64 i64
// ); );
// } }
#[test] #[test]
fn branch_first_float() { fn branch_first_float() {