From beccc92c870e95021a6cc26c03ffed2b3cee2474 Mon Sep 17 00:00:00 2001
From: Ayaz Hafiz <ayaz@rwx.com>
Date: Fri, 22 Jul 2022 16:06:32 -0400
Subject: [PATCH] Support underscores in assignment patterns

---
 crates/compiler/can/src/pattern.rs         | 15 +--------------
 crates/compiler/problem/src/can.rs         |  1 -
 crates/compiler/solve/tests/solve_expr.rs  | 16 +++++++++++++++-
 crates/reporting/src/error/canonicalize.rs |  9 ---------
 4 files changed, 16 insertions(+), 25 deletions(-)

diff --git a/crates/compiler/can/src/pattern.rs b/crates/compiler/can/src/pattern.rs
index a357195e37..eda874f534 100644
--- a/crates/compiler/can/src/pattern.rs
+++ b/crates/compiler/can/src/pattern.rs
@@ -384,10 +384,7 @@ pub fn canonicalize_pattern<'a>(
             ptype => unsupported_pattern(env, ptype, region),
         },
 
-        Underscore(_) => match pattern_type {
-            WhenBranch | FunctionArg => Pattern::Underscore,
-            TopLevelDef | DefExpr => bad_underscore(env, region),
-        },
+        Underscore(_) => Pattern::Underscore,
 
         &NumLiteral(str) => match pattern_type {
             WhenBranch => match finish_parsing_num(str) {
@@ -652,16 +649,6 @@ fn unsupported_pattern(env: &mut Env, pattern_type: PatternType, region: Region)
     Pattern::UnsupportedPattern(region)
 }
 
-fn bad_underscore(env: &mut Env, region: Region) -> Pattern {
-    use roc_problem::can::BadPattern;
-    env.problem(Problem::UnsupportedPattern(
-        BadPattern::UnderscoreInDef,
-        region,
-    ));
-
-    Pattern::UnsupportedPattern(region)
-}
-
 /// When we detect a malformed pattern like `3.X` or `0b5`,
 /// report it to Env and return an UnsupportedPattern runtime error pattern.
 fn malformed_pattern(env: &mut Env, problem: MalformedPatternProblem, region: Region) -> Pattern {
diff --git a/crates/compiler/problem/src/can.rs b/crates/compiler/problem/src/can.rs
index 786dca0a4f..40448229a9 100644
--- a/crates/compiler/problem/src/can.rs
+++ b/crates/compiler/problem/src/can.rs
@@ -16,7 +16,6 @@ pub struct CycleEntry {
 
 #[derive(Clone, Debug, PartialEq)]
 pub enum BadPattern {
-    UnderscoreInDef,
     Unsupported(PatternType),
 }
 
diff --git a/crates/compiler/solve/tests/solve_expr.rs b/crates/compiler/solve/tests/solve_expr.rs
index f113c86872..12f334a957 100644
--- a/crates/compiler/solve/tests/solve_expr.rs
+++ b/crates/compiler/solve/tests/solve_expr.rs
@@ -7438,6 +7438,20 @@ mod solve_expr {
                 "#
             ),
             @r#"x : { a : [A { b : [B]* }*]* }*"#
-        )
+        );
+    }
+
+    #[test]
+    fn infer_type_with_underscore_destructure_assignment() {
+        infer_eq_without_problem(
+            indoc!(
+                r#"
+                Pair x _ = Pair 0 1
+
+                x
+                "#
+            ),
+            "Num *",
+        );
     }
 }
diff --git a/crates/reporting/src/error/canonicalize.rs b/crates/reporting/src/error/canonicalize.rs
index 95db95bae1..37d53e8515 100644
--- a/crates/reporting/src/error/canonicalize.rs
+++ b/crates/reporting/src/error/canonicalize.rs
@@ -192,15 +192,6 @@ pub fn can_problem<'b>(
             title = SYNTAX_PROBLEM.to_string();
             severity = Severity::RuntimeError;
         }
-        Problem::UnsupportedPattern(BadPattern::UnderscoreInDef, region) => {
-            doc = alloc.stack([
-                alloc.reflow("Underscore patterns are not allowed in definitions"),
-                alloc.region(lines.convert_region(region)),
-            ]);
-
-            title = SYNTAX_PROBLEM.to_string();
-            severity = Severity::RuntimeError;
-        }
         Problem::UnsupportedPattern(BadPattern::Unsupported(pattern_type), region) => {
             use roc_parse::pattern::PatternType::*;