language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-09-27 05:49:08 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

make sure RCX register does not alias an argument

Browse source
This commit is contained in:
Folkert 2022-09-07 20:09:22 +02:00
parent 7cc5aa243b
commit c0a7b283f9
No known key found for this signature in database
GPG key ID: 1F17F6FFD112B97C
1 changed files with 18 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

35
crates/compiler/gen_dev/src/generic64/x86_64.rs
View file

@ -1463,14 +1463,7 @@ impl Assembler<X86_64GeneralReg, X86_64FloatReg> for X86_64Assembler {
ASM: Assembler<X86_64GeneralReg, X86_64FloatReg>,
CC: CallConv<X86_64GeneralReg, X86_64FloatReg, ASM>,
{
use crate::generic64::RegStorage;
storage_manager.ensure_reg_free(buf, RegStorage::General(X86_64GeneralReg::RCX));
mov_reg64_reg64(buf, dst, src1);
mov_reg64_reg64(buf, X86_64GeneralReg::RCX, src2);
shl_reg64_reg64(buf, dst)
shift_reg64_reg64_reg64(buf, storage_manager, shl_reg64_reg64, dst, src1, src2)
}
fn shr_reg64_reg64_reg64<'a, 'r, ASM, CC>(
@ -1483,14 +1476,7 @@ impl Assembler<X86_64GeneralReg, X86_64FloatReg> for X86_64Assembler {
ASM: Assembler<X86_64GeneralReg, X86_64FloatReg>,
CC: CallConv<X86_64GeneralReg, X86_64FloatReg, ASM>,
{
use crate::generic64::RegStorage;
storage_manager.ensure_reg_free(buf, RegStorage::General(X86_64GeneralReg::RCX));
mov_reg64_reg64(buf, dst, src1);
mov_reg64_reg64(buf, X86_64GeneralReg::RCX, src2);
shr_reg64_reg64(buf, dst)
shift_reg64_reg64_reg64(buf, storage_manager, shr_reg64_reg64, dst, src1, src2)
}
fn sar_reg64_reg64_reg64<'a, 'r, ASM, CC>(
@ -1527,7 +1513,22 @@ fn shift_reg64_reg64_reg64<'a, 'r, ASM, CC>(
}};
}
helper!(buf, dst, src1, src2)
// if RCX is one of our input registers, we need to move some stuff around
if let X86_64GeneralReg::RCX = dst {
storage_manager.with_tmp_general_reg(buf, |_, buf, tmp| {
helper!(buf, tmp, src1, src2);
mov_reg64_reg64(buf, dst, tmp);
})
} else if let X86_64GeneralReg::RCX = src2 {
storage_manager.with_tmp_general_reg(buf, |_, buf, tmp| {
mov_reg64_reg64(buf, tmp, src2);
helper!(buf, dst, src1, tmp);
})
} else {
helper!(buf, dst, src1, src2)
}
}
impl X86_64Assembler {