Merge pull request #4463 from roc-lang/clippy-1.65

clippy 1.65

crates/compiler/parse/src/ast.rs

@@ -109,7 +109,7 @@ pub enum StrSegment<'a> {
     Interpolated(Loc<&'a Expr<'a>>), // e.g. (name) in "Hi, \(name)!"
 }
 
-#[derive(Clone, Copy, Debug, PartialEq)]
+#[derive(Clone, Copy, Debug, PartialEq, Eq)]
 pub enum EscapedChar {
     Newline,        // \n
     Tab,            // \t
@@ -581,7 +581,7 @@ pub enum AssignedField<'a, Val> {
     Malformed(&'a str),
 }
 
-#[derive(Clone, Copy, Debug, PartialEq)]
+#[derive(Clone, Copy, Debug, PartialEq, Eq)]
 pub enum CommentOrNewline<'a> {
     Newline,
     LineComment(&'a str),
@@ -880,7 +880,7 @@ impl<'a, T> Collection<'a, T> {
 
     pub fn final_comments(&self) -> &'a [CommentOrNewline<'a>] {
         if let Some(final_comments) = self.final_comments {
-            *final_comments
+            final_comments
         } else {
             &[]
         }

crates/compiler/parse/src/expr.rs

@@ -547,7 +547,7 @@ fn numeric_negate_expression<'a, T>(
     expr: Loc<Expr<'a>>,
     spaces: &'a [CommentOrNewline<'a>],
 ) -> Loc<Expr<'a>> {
-    debug_assert_eq!(state.bytes().get(0), Some(&b'-'));
+    debug_assert_eq!(state.bytes().first(), Some(&b'-'));
     // for overflow reasons, we must make the unary minus part of the number literal.
     let start = state.pos();
     let region = Region::new(start, expr.region.end());
@@ -942,7 +942,7 @@ fn parse_defs_end<'a>(
                                             ann_type: arena.alloc(*ann_type),
                                             comment,
                                             body_pattern: arena.alloc(loc_pattern),
-                                            body_expr: *arena.alloc(loc_def_expr),
+                                            body_expr: arena.alloc(loc_def_expr),
                                         };
 
                                         let region =
@@ -981,7 +981,7 @@ fn parse_defs_end<'a>(
                                             ann_type: arena.alloc(*ann_type),
                                             comment,
                                             body_pattern: arena.alloc(loc_pattern),
-                                            body_expr: *arena.alloc(loc_def_expr),
+                                            body_expr: arena.alloc(loc_def_expr),
                                         };
 
                                         let region =
@@ -1905,7 +1905,7 @@ fn expr_to_pattern_help<'a>(arena: &'a Bump, expr: &Expr<'a>) -> Result<Pattern<
         | Expr::UnaryOp(_, _) => Err(()),
 
         Expr::Str(string) => Ok(Pattern::StrLiteral(*string)),
-        Expr::SingleQuote(string) => Ok(Pattern::SingleQuote(*string)),
+        Expr::SingleQuote(string) => Ok(Pattern::SingleQuote(string)),
         Expr::MalformedIdent(string, _problem) => Ok(Pattern::Malformed(string)),
     }
 }

crates/compiler/parse/src/header.rs

@@ -52,7 +52,7 @@ pub enum VersionComparison {
     DisallowsEqual,
 }
 
-#[derive(Copy, Clone, PartialEq, Debug)]
+#[derive(Copy, Clone, PartialEq, Eq, Debug)]
 pub struct PackageName<'a>(&'a str);
 
 impl<'a> PackageName<'a> {
@@ -160,7 +160,7 @@ pub struct HostedHeader<'a> {
     pub after_with: &'a [CommentOrNewline<'a>],
 }
 
-#[derive(Copy, Clone, Debug, PartialEq)]
+#[derive(Copy, Clone, Debug, PartialEq, Eq)]
 pub enum To<'a> {
     ExistingPackage(&'a str),
     NewPackage(PackageName<'a>),
@@ -262,7 +262,7 @@ pub struct TypedIdent<'a> {
     pub ann: Loc<TypeAnnotation<'a>>,
 }
 
-#[derive(Copy, Clone, Debug, PartialEq)]
+#[derive(Copy, Clone, Debug, PartialEq, Eq)]
 pub struct PackageEntry<'a> {
     pub shorthand: &'a str,
     pub spaces_after_shorthand: &'a [CommentOrNewline<'a>],

crates/compiler/parse/src/string_literal.rs

@@ -122,10 +122,7 @@ pub fn parse_single_quote<'a>() -> impl Parser<'a, &'a str, EString<'a>> {
     }
 }
 
-fn consume_indent<'a>(
-    mut state: State<'a>,
-    mut indent: u32,
-) -> Result<State, (Progress, EString<'a>, State<'a>)> {
+fn consume_indent(mut state: State, mut indent: u32) -> Result<State, (Progress, EString, State)> {
     while indent > 0 {
         match state.bytes().first() {
             Some(b' ') => {