language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-09-30 15:21:12 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

use new sccs in error case too

Browse source
This commit is contained in:
Folkert 2022-04-22 15:01:53 +02:00
parent 887acb7519
commit c763d51551
No known key found for this signature in database
GPG key ID: 1F17F6FFD112B97C
1 changed files with 7 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

14
compiler/can/src/def.rs
View file

@ -976,13 +976,13 @@ pub fn sort_can_defs_improved(
// //
// foo = if b then foo else bar // foo = if b then foo else bar
let all_successors_without_self = |id: &u32| { let sccs = strongly_connected_components_improved(
let id = *id; def_ids.length as usize,
def_ids.successors_without_self(id) &def_ids.references,
}; &nodes_in_cycle,
);
for cycle in strongly_connected_components(&nodes_in_cycle, all_successors_without_self) for cycle in sccs {
{
// check whether the cycle is faulty, which is when it has // check whether the cycle is faulty, which is when it has
// a direct successor in the current cycle. This catches things like: // a direct successor in the current cycle. This catches things like:
// //
@ -1063,7 +1063,7 @@ pub fn sort_can_defs_improved(
// for each symbol in this group // for each symbol in this group
for symbol in &groups[*group_id] { for symbol in &groups[*group_id] {
// find its successors // find its successors
for succ in all_successors_without_self(symbol) { for succ in def_ids.successors_without_self(*symbol) {
// and add its group to the result // and add its group to the result
match symbol_to_group_index.get(&succ) { match symbol_to_group_index.get(&succ) {
Some(index) => { Some(index) => {