Clippy

compiler/constrain/src/builtins.rs

@@ -35,7 +35,7 @@ pub fn add_numeric_bound_constr(
             ));
             total_num_type
         }
-        _ => RangedNumber(Box::new(total_num_type.clone()), range),
+        _ => RangedNumber(Box::new(total_num_type), range),
     }
 }
 
@@ -66,7 +66,7 @@ pub fn int_literal(
             Category::Int,
             region,
         ),
-        Eq(num_type, expected.clone(), Category::Int, region),
+        Eq(num_type, expected, Category::Int, region),
     ]);
 
     exists(vec![num_var], And(constrs))

compiler/constrain/src/pattern.rs

@@ -185,7 +185,7 @@ pub fn constrain_pattern(
 
             let num_type = builtins::add_numeric_bound_constr(
                 &mut state.constraints,
-                num_type.clone(),
+                num_type,
                 bound,
                 region,
                 Category::Num,

compiler/types/src/solved_types.rs

@@ -231,7 +231,7 @@ impl SolvedType {
                 }
             }
             Variable(var) => Self::from_var(solved_subs.inner(), *var),
-            RangedNumber(typ, _) => Self::from_type(solved_subs, &typ),
+            RangedNumber(typ, _) => Self::from_type(solved_subs, typ),
         }
     }
 

compiler/types/src/subs.rs

@@ -1058,6 +1058,7 @@ fn define_integer_types(subs: &mut Subs) {
     );
 }
 
+#[allow(clippy::too_many_arguments)]
 fn float_type(
     subs: &mut Subs,