language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-09-26 13:29:12 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

clippy + comments

Browse source
This commit is contained in:
Brian Carroll 2022-11-21 21:31:58 +00:00
parent 3d7fb380a5
commit ce10199bb4
No known key found for this signature in database
GPG key ID: 5C7B2EC4101703C0
3 changed files with 16 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

25
crates/wasm_interp/src/call_stack.rs
View file

@ -97,23 +97,23 @@ impl<'a> CallStack<'a> {
match value { match value {
Value::I32(x) => { Value::I32(x) => {
self.locals_data[index] = unsafe { std::mem::transmute(x as i64) }; self.locals_data[index] = unsafe { std::mem::transmute(x as i64) };
debug_assert_eq!(self.is_64[index], false); debug_assert!(!self.is_64[index]);
debug_assert_eq!(self.is_float[index], false); debug_assert!(!self.is_float[index]);
} }
Value::I64(x) => { Value::I64(x) => {
self.locals_data[index] = unsafe { std::mem::transmute(x) }; self.locals_data[index] = unsafe { std::mem::transmute(x) };
debug_assert_eq!(self.is_float[index], false); debug_assert!(!self.is_float[index]);
debug_assert_eq!(self.is_64[index], true); debug_assert!(self.is_64[index]);
} }
Value::F32(x) => { Value::F32(x) => {
self.locals_data[index] = x.to_bits() as u64; self.locals_data[index] = x.to_bits() as u64;
debug_assert_eq!(self.is_float[index], true); debug_assert!(self.is_float[index]);
debug_assert_eq!(self.is_64[index], false); debug_assert!(!self.is_64[index]);
} }
Value::F64(x) => { Value::F64(x) => {
self.locals_data[index] = x.to_bits(); self.locals_data[index] = x.to_bits();
debug_assert_eq!(self.is_float[index], true); debug_assert!(self.is_float[index]);
debug_assert_eq!(self.is_64[index], true); debug_assert!(self.is_64[index]);
} }
} }
} }
@ -131,9 +131,12 @@ mod tests {
} }
fn setup(call_stack: &mut CallStack<'_>) { fn setup(call_stack: &mut CallStack<'_>) {
// Push a other few frames before the test frame, just to make the scenario more typical.
call_stack.push_frame(0x11111, &[(1, ValueType::I32)]); call_stack.push_frame(0x11111, &[(1, ValueType::I32)]);
call_stack.push_frame(0x22222, &[(2, ValueType::I32)]); call_stack.push_frame(0x22222, &[(2, ValueType::I32)]);
call_stack.push_frame(0x33333, &[(3, ValueType::I32)]); call_stack.push_frame(0x33333, &[(3, ValueType::I32)]);
// Create a test call frame with local variables of every type
let current_frame_local_decls = [ let current_frame_local_decls = [
(8, ValueType::I32), (8, ValueType::I32),
(4, ValueType::I64), (4, ValueType::I64),
@ -151,7 +154,7 @@ mod tests {
test_get_set(&mut call_stack, 0, Value::I32(123)); test_get_set(&mut call_stack, 0, Value::I32(123));
test_get_set(&mut call_stack, 8, Value::I64(123456)); test_get_set(&mut call_stack, 8, Value::I64(123456));
test_get_set(&mut call_stack, 12, Value::F32(3.14)); test_get_set(&mut call_stack, 12, Value::F32(1.01));
test_get_set(&mut call_stack, 14, Value::F64(-1.1)); test_get_set(&mut call_stack, 14, Value::F64(-1.1));
test_get_set(&mut call_stack, 0, Value::I32(i32::MIN)); test_get_set(&mut call_stack, 0, Value::I32(i32::MIN));
@ -175,7 +178,7 @@ mod tests {
let arena = Bump::new(); let arena = Bump::new();
let mut call_stack = CallStack::new(&arena); let mut call_stack = CallStack::new(&arena);
setup(&mut call_stack); setup(&mut call_stack);
test_get_set(&mut call_stack, 0, Value::F32(3.14)); test_get_set(&mut call_stack, 0, Value::F32(1.01));
} }
#[test] #[test]
@ -184,7 +187,7 @@ mod tests {
let arena = Bump::new(); let arena = Bump::new();
let mut call_stack = CallStack::new(&arena); let mut call_stack = CallStack::new(&arena);
setup(&mut call_stack); setup(&mut call_stack);
test_get_set(&mut call_stack, 8, Value::F32(3.14)); test_get_set(&mut call_stack, 8, Value::F32(1.01));
} }
#[test] #[test]

2
crates/wasm_interp/src/value_stack.rs
View file

@ -169,7 +169,7 @@ mod tests {
const VALUES: [Value; 4] = [ const VALUES: [Value; 4] = [
Value::I32(123), Value::I32(123),
Value::I64(123456), Value::I64(123456),
Value::F32(3.14), Value::F32(1.01),
Value::F64(-1.1), Value::F64(-1.1),
]; ];

1
crates/wasm_module/src/sections.rs
View file

@ -610,6 +610,7 @@ pub struct TableSection {
impl TableSection { impl TableSection {
const ID: SectionId = SectionId::Table; const ID: SectionId = SectionId::Table;
#[allow(clippy::new_without_default)]
pub fn new() -> Self { pub fn new() -> Self {
TableSection { TableSection {
function_table: TableType { function_table: TableType {