language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-09-24 20:42:29 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

swap_remove rather than removing in place

Browse source
This commit is contained in:
Ayaz Hafiz 2022-08-13 10:30:58 -07:00
parent 7215acdbac
commit d19c9107b2
No known key found for this signature in database
GPG key ID: 0E2A37416A25EF58
1 changed files with 5 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

7
crates/compiler/can/src/module.rs
View file

@ -988,9 +988,12 @@ fn fix_values_captured_in_closure_expr(
// initially `outer` captures [inner], but this is then replaced with just [x].
let (captured_symbol, _) = captured_symbols[i];
if let Some(captures) = closure_captures.get(&captured_symbol) {
captured_symbols.remove(i);
debug_assert!(!captures.is_empty());
captured_symbols.swap_remove(i);
captured_symbols.extend(captures);
// Don't advance because the next capture was shifted down.
// Jump two, because the next element is now one of the newly-added captures,
// which we don't need to check.
i += 2;
} else {
i += 1;
}