language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-08-04 20:28:02 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

Merge pull request #6941 from roc-lang/improve-tip

Browse source 
improve opaque types tip
This commit is contained in:
Anton-4 2024-07-31 13:48:51 +02:00 • committed by GitHub
commit d23426ac47
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 16 additions and 27 deletions
Download patch file Download diff file Expand all files Collapse all files

6
crates/cli/tests/cli_run.rs
View file

@ -1484,10 +1484,8 @@ mod cli_run {
Effect.Effect (Result {} [])
Tip: Type comparisons between an opaque type are only ever equal if
both types are the same opaque type. Did you mean to create an opaque
type by wrapping it? If I have an opaque type Age := U32 I can create
an instance of this opaque type by doing @Age 23.
Tip: Add type annotations to functions or values to help you figure
this out.
────────────────────────────────────────────────────────────────────────────────

18
crates/compiler/load/tests/test_reporting.rs
View file

@ -8257,10 +8257,8 @@ All branches in an `if` must have the same type!
F Str
Tip: Type comparisons between an opaque type are only ever equal if
both types are the same opaque type. Did you mean to create an opaque
type by wrapping it? If I have an opaque type Age := U32 I can create
an instance of this opaque type by doing @Age 23.
Tip: *Add type annotations* to functions or values to help you figure
this out.
"#
);
@ -8294,10 +8292,8 @@ All branches in an `if` must have the same type!
Age
Tip: Type comparisons between an opaque type are only ever equal if
both types are the same opaque type. Did you mean to create an opaque
type by wrapping it? If I have an opaque type Age := U32 I can create
an instance of this opaque type by doing @Age 23.
Tip: *Add type annotations* to functions or values to help you figure
this out.
"
);
@ -10420,10 +10416,8 @@ All branches in an `if` must have the same type!
OList
Tip: Type comparisons between an opaque type are only ever equal if
both types are the same opaque type. Did you mean to create an opaque
type by wrapping it? If I have an opaque type Age := U32 I can create
an instance of this opaque type by doing @Age 23.
Tip: *Add type annotations* to functions or values to help you figure
this out.
"
);

19
crates/reporting/src/error/type.rs
View file

@ -4788,17 +4788,14 @@ fn type_problem_to_pretty<'b>(
alloc.reflow("Learn more about optional fields at TODO."),
])),
(OpaqueComparedToNonOpaque, _) => alloc.tip().append(alloc.concat([
alloc.reflow(
"Type comparisons between an opaque type are only ever \
equal if both types are the same opaque type. Did you mean \
to create an opaque type by wrapping it? If I have an opaque type ",
),
alloc.type_str("Age := U32"),
alloc.reflow(" I can create an instance of this opaque type by doing "),
alloc.type_str("@Age 23"),
alloc.reflow("."),
])),
(OpaqueComparedToNonOpaque, _) => alloc.tip().append(
alloc.concat([
alloc
.reflow("Add type annotations")
.annotate(Annotation::Emphasized),
alloc.reflow(" to functions or values to help you figure this out."),
]),
),
(BoolVsBoolTag(tag), _) => alloc.tip().append(alloc.concat([
alloc.reflow("Did you mean to use "),