language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-10-01 07:41:12 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

clarify import constraint

Browse source
This commit is contained in:
Folkert 2022-03-13 17:59:33 +01:00
parent b3f7b3a337
commit d31ea3e71f
No known key found for this signature in database
GPG key ID: 1F17F6FFD112B97C
1 changed files with 5 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

9
compiler/can/src/constraint.rs
View file

@ -404,10 +404,11 @@ impl Constraints {
/// we use a StorageSubs to store the data, and copy over the relevant
/// variables/content/flattype/tagname etc.
///
/// The aim of that process is to simulate what `type_to_var` (solve.rs) does to a `Type`.
/// The general idea is to let-generalize the imorted types in the target module.
/// More concretely, we need to simulate what `type_to_var` (solve.rs) does to a `Type`.
/// While the copying puts all the data the right place, it misses that `type_to_var` puts
/// the variables that it creates (to store the nodes of a Type in Subs) in the pool of the
/// current rank.
/// current rank (so they can be generalized).
///
/// So, during copying of an import (`copy_import_to`, subs.rs) we track the variables that
/// we need to put into the pool (simulating what `type_to_var` would do). Those variables
@ -418,7 +419,7 @@ impl Constraints {
&mut self,
rigid_vars: I1,
def_types: I2,
ret_constraint: Constraint,
module_constraint: Constraint,
pool_variables: &[Variable],
) -> Constraint
where
@ -430,7 +431,7 @@ impl Constraints {
let defs_and_ret_constraint = Index::new(self.constraints.len() as _);
self.constraints.push(Constraint::True);
self.constraints.push(ret_constraint);
self.constraints.push(module_constraint);
let let_contraint = LetConstraint {
rigid_vars: self.variable_slice(rigid_vars),