language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-09-28 22:34:45 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Wasm tests: speed up 3x by only exporting refcount symbols when used

Browse source 
49s vs 2m10s
This commit is contained in:
Brian Carroll 2021-12-31 11:14:43 +00:00
parent f767014f30
commit d66d432716
1 changed files with 17 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

23
compiler/test_gen/src/helpers/wasm.rs
View file

@ -36,12 +36,18 @@ fn promote_expr_to_module(src: &str) -> String {
buffer buffer
} }
pub enum BuildType {
Evaluate,
Refcount,
}
#[allow(dead_code)] #[allow(dead_code)]
pub fn compile_and_load<'a, T: Wasm32TestResult>( pub fn compile_and_load<'a, T: Wasm32TestResult>(
arena: &'a bumpalo::Bump, arena: &'a bumpalo::Bump,
src: &str, src: &str,
stdlib: &'a roc_builtins::std::StdLib, stdlib: &'a roc_builtins::std::StdLib,
_test_wrapper_type_info: PhantomData<T>, _test_wrapper_type_info: PhantomData<T>,
build_type: BuildType,
) -> wasmer::Instance { ) -> wasmer::Instance {
use std::path::{Path, PathBuf}; use std::path::{Path, PathBuf};
@ -161,7 +167,7 @@ pub fn compile_and_load<'a, T: Wasm32TestResult>(
// write the module to a file so the linker can access it // write the module to a file so the linker can access it
std::fs::write(&app_o_file, &module_bytes).unwrap(); std::fs::write(&app_o_file, &module_bytes).unwrap();
let args = &[ let mut args = vec![
"wasm-ld", "wasm-ld",
// input files // input files
app_o_file.to_str().unwrap(), app_o_file.to_str().unwrap(),
@ -182,13 +188,16 @@ pub fn compile_and_load<'a, T: Wasm32TestResult>(
"--export", "--export",
"test_wrapper", "test_wrapper",
"--export", "--export",
"init_refcount_test",
"--export",
"#UserApp_main_1", "#UserApp_main_1",
]; ];
// For some reason, this makes linking ~3x slower
if matches!(build_type, BuildType::Refcount) {
args.extend_from_slice(&["--export", "init_refcount_test"]);
}
let linker_output = std::process::Command::new(&crate::helpers::zig_executable()) let linker_output = std::process::Command::new(&crate::helpers::zig_executable())
.args(args) .args(&args)
.output() .output()
.unwrap(); .unwrap();
@ -227,7 +236,8 @@ where
// NOTE the stdlib must be in the arena; just taking a reference will segfault // NOTE the stdlib must be in the arena; just taking a reference will segfault
let stdlib = arena.alloc(roc_builtins::std::standard_stdlib()); let stdlib = arena.alloc(roc_builtins::std::standard_stdlib());
let instance = crate::helpers::wasm::compile_and_load(&arena, src, stdlib, phantom); let instance =
crate::helpers::wasm::compile_and_load(&arena, src, stdlib, phantom, BuildType::Evaluate);
let memory = instance.exports.get_memory(MEMORY_NAME).unwrap(); let memory = instance.exports.get_memory(MEMORY_NAME).unwrap();
@ -272,7 +282,8 @@ where
// NOTE the stdlib must be in the arena; just taking a reference will segfault // NOTE the stdlib must be in the arena; just taking a reference will segfault
let stdlib = arena.alloc(roc_builtins::std::standard_stdlib()); let stdlib = arena.alloc(roc_builtins::std::standard_stdlib());
let instance = crate::helpers::wasm::compile_and_load(&arena, src, stdlib, phantom); let instance =
crate::helpers::wasm::compile_and_load(&arena, src, stdlib, phantom, BuildType::Refcount);
let memory = instance.exports.get_memory(MEMORY_NAME).unwrap(); let memory = instance.exports.get_memory(MEMORY_NAME).unwrap();