From 3f3ac3165679dac0c686c462ae031394be4be498 Mon Sep 17 00:00:00 2001 From: Christopher Duncan Date: Tue, 11 Oct 2022 07:20:32 -0400 Subject: [PATCH 1/7] Test whether broken links will cause CI to fail --- .github/workflows/markdown_link_check.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/markdown_link_check.yml b/.github/workflows/markdown_link_check.yml index 2e72934d3b..70568ae433 100644 --- a/.github/workflows/markdown_link_check.yml +++ b/.github/workflows/markdown_link_check.yml @@ -15,5 +15,4 @@ jobs: with: use-quiet-mode: 'yes' use-verbose-mode: 'yes' - check-modified-files-only: 'yes' base-branch: 'main' From e086187f3cb66d3961b4a0abc4e9076265605791 Mon Sep 17 00:00:00 2001 From: Christopher Duncan Date: Tue, 11 Oct 2022 07:25:45 -0400 Subject: [PATCH 2/7] Repair links in Markdown This resolves #3832 --- CONTRIBUTING.md | 4 ++-- crates/compiler/gen_dev/README.md | 2 +- crates/editor/README.md | 4 ++-- mlc_config.json | 40 +++++++++++++++++++++++++++++++ 4 files changed, 45 insertions(+), 5 deletions(-) create mode 100644 mlc_config.json diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index ffc181aa02..7a61e0fe64 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -2,7 +2,7 @@ ## Code of Conduct -We are committed to providing a friendly, safe and welcoming environment for all. Make sure to take a look at the [Code of Conduct](CodeOfConduct.md)! +We are committed to providing a friendly, safe and welcoming environment for all. Make sure to take a look at the [Code of Conduct](CODE_OF_CONDUCT.md)! ## How to contribute @@ -23,7 +23,7 @@ Check [Building from source](BUILDING_FROM_SOURCE.md) for instructions. ## Running Tests -Most contributors execute the following commands befor pushing their code: +Most contributors execute the following commands before pushing their code: ```sh cargo test diff --git a/crates/compiler/gen_dev/README.md b/crates/compiler/gen_dev/README.md index 2972eeb7ef..15cffb0bc4 100644 --- a/crates/compiler/gen_dev/README.md +++ b/crates/compiler/gen_dev/README.md @@ -88,7 +88,7 @@ This is the general procedure I follow with some helpful links: ## Helpful Resources -- [Compiler Explorer](godbolt.org) - +- [Compiler Explorer](https://godbolt.org/) - Generates assembly from most languages. Really good for getting a reference for what is required to do something. Can answer questions like "how would x be implemented in arm assembly?" diff --git a/crates/editor/README.md b/crates/editor/README.md index cb288b1fed..58ce9aeab0 100644 --- a/crates/editor/README.md +++ b/crates/editor/README.md @@ -6,7 +6,7 @@ Unlike most editors, we use projectional or structural editing to edit the [Abst ## Getting started -- Install the compiler, see [here](../BUILDING_FROM_SOURCE.md). +- Install the compiler, see [here](../../BUILDING_FROM_SOURCE.md). - Run the following from the roc folder: ```sh @@ -75,4 +75,4 @@ Important folders/files outside the editor folder: ## Contributing We welcome new contributors :heart: and are happy to help you get started. -Check [CONTRIBUTING.md](../CONTRIBUTING.md) for more info. +Check [CONTRIBUTING.md](../../CONTRIBUTING.md) for more info. diff --git a/mlc_config.json b/mlc_config.json new file mode 100644 index 0000000000..f90ce765c4 --- /dev/null +++ b/mlc_config.json @@ -0,0 +1,40 @@ +{ + "ignorePatterns": [ + { + "pattern": "http://127.0.0.1" + }, + { + "pattern": "https://www.codegrepper.com" + }, + { + "pattern": "https://crates.io" + }, + { + "pattern": "http://deum-longis.org" + }, + { + "pattern": "http://ergohoc.com" + }, + { + "pattern": "http://www.in-ulla.io" + }, + { + "pattern": "http://inplevere-virum.net" + }, + { + "pattern": "http://latonam.com" + }, + { + "pattern": "http://localhost" + }, + { + "pattern": "http://moleorbataque.io" + }, + { + "pattern": "http://occideratparem.io" + }, + { + "pattern": "http://pedesque-huius.org" + } + ] +} \ No newline at end of file From f7dd5ca70869d2cf629ad5a32075d7be180afcff Mon Sep 17 00:00:00 2001 From: Anton-4 <17049058+Anton-4@users.noreply.github.com> Date: Sat, 15 Oct 2022 12:21:59 +0200 Subject: [PATCH 3/7] replace random links with roc-lang.org random links are generated by the lorem ipsum generator, we don't want to allow a bunch of random links in the repo for security purposes. Signed-off-by: Anton-4 <17049058+Anton-4@users.noreply.github.com> --- examples/static-site-gen/input/apple.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/examples/static-site-gen/input/apple.md b/examples/static-site-gen/input/apple.md index 426fd019b1..cd271fede6 100644 --- a/examples/static-site-gen/input/apple.md +++ b/examples/static-site-gen/input/apple.md @@ -16,7 +16,7 @@ Livor nulla Pallantias virtutis fluctus testantia inponis et tenuerunt clipeo non sacra date *partes* quoque fugae; cum. Audax contingere moresque dis requirere senserit spectare generosos formatum modo edidit abluere his infixum inductae dis concipe nisi redeuntia. Lutulenta [sublimibus pudori -iussis](http://latonam.com/) volucrem recumbis foresque, tecum mater sidus est +iussis](https://www.roc-lang.org/) volucrem recumbis foresque, tecum mater sidus est imagine. Et dea diebus me corpora nunc. Iam parte medium obscuraque **Acheloia** ad iubes @@ -62,6 +62,6 @@ Herculei undae calcata inmeriti quercus ignes parabant iam. Foret inpendere, haec ipse ossa, dolentes das Caystro miscuit iunctoque spoliantis illae, ex! Bello istis nunc Aegides? Animo caelestia melior, -furoribus optat maior invecta quid harenis [est](http://in.com/) sollemnia modo +furoribus optat maior invecta quid harenis [est](https://www.roc-lang.org/) sollemnia modo Phineu. Suarum pectora. Relinquam in labore Medusae sororem Herculis [simillima -corpora](http://ergohoc.com/dixiexcusat) plus regi ignibus, totum domus! \ No newline at end of file +corpora](https://www.roc-lang.org/) plus regi ignibus, totum domus! From 52bc03e93b76bde774306dd26a3ebb19da0ab04e Mon Sep 17 00:00:00 2001 From: Anton-4 <17049058+Anton-4@users.noreply.github.com> Date: Sat, 15 Oct 2022 12:23:43 +0200 Subject: [PATCH 4/7] remove lorem ipsum patterns Signed-off-by: Anton-4 <17049058+Anton-4@users.noreply.github.com> --- mlc_config.json | 32 +------------------------------- 1 file changed, 1 insertion(+), 31 deletions(-) diff --git a/mlc_config.json b/mlc_config.json index f90ce765c4..40c56109a6 100644 --- a/mlc_config.json +++ b/mlc_config.json @@ -3,38 +3,8 @@ { "pattern": "http://127.0.0.1" }, - { - "pattern": "https://www.codegrepper.com" - }, - { - "pattern": "https://crates.io" - }, - { - "pattern": "http://deum-longis.org" - }, - { - "pattern": "http://ergohoc.com" - }, - { - "pattern": "http://www.in-ulla.io" - }, - { - "pattern": "http://inplevere-virum.net" - }, - { - "pattern": "http://latonam.com" - }, { "pattern": "http://localhost" - }, - { - "pattern": "http://moleorbataque.io" - }, - { - "pattern": "http://occideratparem.io" - }, - { - "pattern": "http://pedesque-huius.org" } ] -} \ No newline at end of file +} From eb727bd8b01b19a5fb21833f0c334ac81d65e031 Mon Sep 17 00:00:00 2001 From: Anton-4 <17049058+Anton-4@users.noreply.github.com> Date: Sat, 15 Oct 2022 14:25:03 +0200 Subject: [PATCH 5/7] fixed links, minimal exceptions Replaced lorem ipsum links with links to roc-lang. All exceptions added are due to problems with those sites and their interaction with programs like curl --- crates/editor/editor-ideas.md | 4 ++-- examples/static-site-gen/input/banana.md | 10 +++++----- examples/static-site-gen/input/cherry.md | 6 +++--- mlc_config.json | 9 +++++++++ 4 files changed, 19 insertions(+), 10 deletions(-) diff --git a/crates/editor/editor-ideas.md b/crates/editor/editor-ideas.md index 37744b3d58..e5c1040480 100644 --- a/crates/editor/editor-ideas.md +++ b/crates/editor/editor-ideas.md @@ -238,7 +238,7 @@ e.g. you have a test `calculate_sum_test` that only uses the function `add`, whe - [Aroma](https://ai.facebook.com/blog/aroma-ml-for-code-recommendation) showing examples similar to current code. - [MISM](https://arxiv.org/abs/2006.05265) neural network based code similarity scoring. - [Inquisitive code editor](https://web.eecs.utk.edu/~azh/blog/inquisitivecodeeditor.html) Interactive bug detection with doc+test generation. -- [NextJournal](https://nextjournal.com/joe-loco/command-bar?token=DpU6ewNQnLhYtVkwhs9GeX) Discoverable commands and shortcuts. +- [NextJournal](https://nextjournal.com/blog/command-bar) Discoverable commands and shortcuts. - [Code Ribbon](https://web.eecs.utk.edu/~azh/blog/coderibbon.html) fast navigation between files. Feature suggestion: top and down are filled with suggested files, whereas left and right are manually filled. - [Automatic data transformation based on examples](https://youtu.be/Ej91F1fpmEw). Feature suggestion: use in combination with voice commands: e.g. "only keep time from list of datetimes". - [Codesee](https://www.codesee.io/) code base visualization. @@ -318,7 +318,7 @@ If we make an integrated terminal, we can automatically add executed commands to ### Inspiration - [Boop](https://github.com/IvanMathy/Boop) scriptable scratchpad for developers. Contains collection of useful conversions: json formatting, url encoding, encode to base64... -- [processing](processing.org) Interactive editor, dragging left or right with mouse to change values. Instant results. +- [processing](https://processing.org) Interactive editor, dragging left or right with mouse to change values. Instant results. - [flowistry](https://github.com/willcrichton/flowistry) easily track all named values in a certain expression throughout your program. ## High performance diff --git a/examples/static-site-gen/input/banana.md b/examples/static-site-gen/input/banana.md index df5625703f..22a6a1ef70 100644 --- a/examples/static-site-gen/input/banana.md +++ b/examples/static-site-gen/input/banana.md @@ -5,12 +5,12 @@ Lorem markdownum praecessit *cesserat suam multos* quam. Est Ulixis inter fabricataque auxilioque fossae et *gravidis arbore*, una verum steterat conamina videre negetur, ista. Isque nubibus et et iam postquam, madefacta cura lugenti -longique somnoque. Resurgere ceu [magnus et](http://et.net/cum) Acheloe, Iovis +longique somnoque. Resurgere ceu [magnus et](https://www.roc-lang.org/) Acheloe, Iovis fatifero alias. In suo Venus nec fixerat Hercule quisve et coronat tauros sol Erinys arces; postquam e natus, ille annis? Hoc sedes. Ait ait! Clarum excidit collocat, inpluit lacrimabile -[herbis](http://dum.org/), et **quod** quid nutricis auctor pompa: anguigenae +[herbis](https://www.roc-lang.org/), et **quod** quid nutricis auctor pompa: anguigenae quo at trahit dum? Me sponsa confundere orant fecit tendentem flamina veteris; ut. Dabat fecit. @@ -25,12 +25,12 @@ ut. Dabat fecit. Et non miseranda eadem ferrum, mersaeque fossa lacrimam Dromas, tempore me iam Perseus valido. Vinaque viderat habet curaque caelo sine *speluncae est* ignarus Teucras quantum. Tanta timet auxilioque -[praecordia](http://pedesque-huius.org/non-quod) unum: legi pondus nacta, est +[praecordia](https://www.roc-lang.org/) unum: legi pondus nacta, est est agnus erat solantia tenet? Scire virgo felix grandior haut. Montibus illi: vir prior, indutus est contra hos, semina saltuque: hoc radiis alter, intravit. Oravique sed ipsa -[cornu](http://inplevere-virum.net/), flere unam suis vindicta spumigeroque +[cornu](https://www.roc-lang.org/), flere unam suis vindicta spumigeroque munere fertur figurae saecula mutentur. In suam corpus nare tumulos ignorat. ## Fraudo Sibyllae mare @@ -45,6 +45,6 @@ prius: que auras insequitur adversas; ab miserata dominam genitor. Oculos gravitate clipeum ab quid dubiaque apertum celerem vidit caput sine dant *adstitit*. Acerbo in *bona verba* tutus est ullus metas primus: suo forte tuam -quaterque vincant Minos, [adverso](http://www.in-ulla.io/saxoque). +quaterque vincant Minos, [adverso](https://www.roc-lang.org/). Longa velut pietate. Erat felix avis Erinyn? diff --git a/examples/static-site-gen/input/cherry.md b/examples/static-site-gen/input/cherry.md index dce374b515..3fbdcbc715 100644 --- a/examples/static-site-gen/input/cherry.md +++ b/examples/static-site-gen/input/cherry.md @@ -9,7 +9,7 @@ criminis quidem petita *ferreus*. Achaidas traxit ad, iacuere iamdudum ab fecit: vestra evicere lacrimis labore: gavisus forti turba. A vixque incesto et tanti paries, columnae est signis -munera? Grata Parcarum [Aetolius modo](http://moleorbataque.io/): meis quanto +munera? Grata Parcarum [Aetolius modo](https://www.roc-lang.org/): meis quanto amico oravit venit mihi vertit summam. ## Terras ab neque moveri mater oculos me @@ -27,7 +27,7 @@ caespes** urbes. ## Fraude stimulis -[Templis quotiens](http://occideratparem.io/vulnus) tectus tuo ignara orbi +[Templis quotiens](https://www.roc-lang.org/) tectus tuo ignara orbi Zanclen hunc comprenditur *momordi*. Armis nymphae. Vocant rupe omnia cognosceret fine; per sonant, deque magnum, suo. @@ -39,7 +39,7 @@ cognosceret fine; per sonant, deque magnum, suo. - Auras Ceycis petit mundo ter sensi sacrum Nosti et spem; tum illa parentes doctas nuntia **laeva virusque**. Magistris -[diversi](http://deum-longis.org/) lacerare at data margine abesset inscribit +[diversi](https://www.roc-lang.org/) lacerare at data margine abesset inscribit calidumque **copia vidit** attulerat altera incensaque crista versus. Fecit et posco series dextra. Lacrimis inducta imis non apertos saeva **ripas sumpserat** pariter quoque aequales. diff --git a/mlc_config.json b/mlc_config.json index 40c56109a6..a5bd459fa2 100644 --- a/mlc_config.json +++ b/mlc_config.json @@ -5,6 +5,15 @@ }, { "pattern": "http://localhost" + }, + { + "pattern": "https://crates.io" + }, + { + "pattern": "https://docs.github.com" + }, + { + "pattern": "https://opensource.org" } ] } From 0d58a7cf8ae18efbb81f9b293f061845a6afd08b Mon Sep 17 00:00:00 2001 From: Anton-4 <17049058+Anton-4@users.noreply.github.com> Date: Sat, 15 Oct 2022 14:28:56 +0200 Subject: [PATCH 6/7] example.org is better --- examples/static-site-gen/input/apple.md | 6 +++--- examples/static-site-gen/input/banana.md | 10 +++++----- examples/static-site-gen/input/cherry.md | 6 +++--- 3 files changed, 11 insertions(+), 11 deletions(-) diff --git a/examples/static-site-gen/input/apple.md b/examples/static-site-gen/input/apple.md index cd271fede6..f4e28c985d 100644 --- a/examples/static-site-gen/input/apple.md +++ b/examples/static-site-gen/input/apple.md @@ -16,7 +16,7 @@ Livor nulla Pallantias virtutis fluctus testantia inponis et tenuerunt clipeo non sacra date *partes* quoque fugae; cum. Audax contingere moresque dis requirere senserit spectare generosos formatum modo edidit abluere his infixum inductae dis concipe nisi redeuntia. Lutulenta [sublimibus pudori -iussis](https://www.roc-lang.org/) volucrem recumbis foresque, tecum mater sidus est +iussis](http://example.org) volucrem recumbis foresque, tecum mater sidus est imagine. Et dea diebus me corpora nunc. Iam parte medium obscuraque **Acheloia** ad iubes @@ -62,6 +62,6 @@ Herculei undae calcata inmeriti quercus ignes parabant iam. Foret inpendere, haec ipse ossa, dolentes das Caystro miscuit iunctoque spoliantis illae, ex! Bello istis nunc Aegides? Animo caelestia melior, -furoribus optat maior invecta quid harenis [est](https://www.roc-lang.org/) sollemnia modo +furoribus optat maior invecta quid harenis [est](http://example.org) sollemnia modo Phineu. Suarum pectora. Relinquam in labore Medusae sororem Herculis [simillima -corpora](https://www.roc-lang.org/) plus regi ignibus, totum domus! +corpora](http://example.org) plus regi ignibus, totum domus! diff --git a/examples/static-site-gen/input/banana.md b/examples/static-site-gen/input/banana.md index 22a6a1ef70..767b6f6e27 100644 --- a/examples/static-site-gen/input/banana.md +++ b/examples/static-site-gen/input/banana.md @@ -5,12 +5,12 @@ Lorem markdownum praecessit *cesserat suam multos* quam. Est Ulixis inter fabricataque auxilioque fossae et *gravidis arbore*, una verum steterat conamina videre negetur, ista. Isque nubibus et et iam postquam, madefacta cura lugenti -longique somnoque. Resurgere ceu [magnus et](https://www.roc-lang.org/) Acheloe, Iovis +longique somnoque. Resurgere ceu [magnus et](http://example.org) Acheloe, Iovis fatifero alias. In suo Venus nec fixerat Hercule quisve et coronat tauros sol Erinys arces; postquam e natus, ille annis? Hoc sedes. Ait ait! Clarum excidit collocat, inpluit lacrimabile -[herbis](https://www.roc-lang.org/), et **quod** quid nutricis auctor pompa: anguigenae +[herbis](http://example.org), et **quod** quid nutricis auctor pompa: anguigenae quo at trahit dum? Me sponsa confundere orant fecit tendentem flamina veteris; ut. Dabat fecit. @@ -25,12 +25,12 @@ ut. Dabat fecit. Et non miseranda eadem ferrum, mersaeque fossa lacrimam Dromas, tempore me iam Perseus valido. Vinaque viderat habet curaque caelo sine *speluncae est* ignarus Teucras quantum. Tanta timet auxilioque -[praecordia](https://www.roc-lang.org/) unum: legi pondus nacta, est +[praecordia](http://example.org) unum: legi pondus nacta, est est agnus erat solantia tenet? Scire virgo felix grandior haut. Montibus illi: vir prior, indutus est contra hos, semina saltuque: hoc radiis alter, intravit. Oravique sed ipsa -[cornu](https://www.roc-lang.org/), flere unam suis vindicta spumigeroque +[cornu](http://example.org), flere unam suis vindicta spumigeroque munere fertur figurae saecula mutentur. In suam corpus nare tumulos ignorat. ## Fraudo Sibyllae mare @@ -45,6 +45,6 @@ prius: que auras insequitur adversas; ab miserata dominam genitor. Oculos gravitate clipeum ab quid dubiaque apertum celerem vidit caput sine dant *adstitit*. Acerbo in *bona verba* tutus est ullus metas primus: suo forte tuam -quaterque vincant Minos, [adverso](https://www.roc-lang.org/). +quaterque vincant Minos, [adverso](http://example.org). Longa velut pietate. Erat felix avis Erinyn? diff --git a/examples/static-site-gen/input/cherry.md b/examples/static-site-gen/input/cherry.md index 3fbdcbc715..2ae7efbb99 100644 --- a/examples/static-site-gen/input/cherry.md +++ b/examples/static-site-gen/input/cherry.md @@ -9,7 +9,7 @@ criminis quidem petita *ferreus*. Achaidas traxit ad, iacuere iamdudum ab fecit: vestra evicere lacrimis labore: gavisus forti turba. A vixque incesto et tanti paries, columnae est signis -munera? Grata Parcarum [Aetolius modo](https://www.roc-lang.org/): meis quanto +munera? Grata Parcarum [Aetolius modo](http://example.org): meis quanto amico oravit venit mihi vertit summam. ## Terras ab neque moveri mater oculos me @@ -27,7 +27,7 @@ caespes** urbes. ## Fraude stimulis -[Templis quotiens](https://www.roc-lang.org/) tectus tuo ignara orbi +[Templis quotiens](http://example.org) tectus tuo ignara orbi Zanclen hunc comprenditur *momordi*. Armis nymphae. Vocant rupe omnia cognosceret fine; per sonant, deque magnum, suo. @@ -39,7 +39,7 @@ cognosceret fine; per sonant, deque magnum, suo. - Auras Ceycis petit mundo ter sensi sacrum Nosti et spem; tum illa parentes doctas nuntia **laeva virusque**. Magistris -[diversi](https://www.roc-lang.org/) lacerare at data margine abesset inscribit +[diversi](http://example.org) lacerare at data margine abesset inscribit calidumque **copia vidit** attulerat altera incensaque crista versus. Fecit et posco series dextra. Lacrimis inducta imis non apertos saeva **ripas sumpserat** pariter quoque aequales. From 709faee85b2a067f8b52c8b7514c21b5fe84133c Mon Sep 17 00:00:00 2001 From: Anton-4 <17049058+Anton-4@users.noreply.github.com> Date: Sat, 15 Oct 2022 15:25:21 +0200 Subject: [PATCH 7/7] add microsoft research exception Signed-off-by: Anton-4 <17049058+Anton-4@users.noreply.github.com> --- mlc_config.json | 3 +++ 1 file changed, 3 insertions(+) diff --git a/mlc_config.json b/mlc_config.json index a5bd459fa2..af7ab0794b 100644 --- a/mlc_config.json +++ b/mlc_config.json @@ -14,6 +14,9 @@ }, { "pattern": "https://opensource.org" + }, + { + "pattern": "https://www.microsoft.com/en-us/research/wp-content/uploads/2016/07/deforestation-short-cut.pdf" } ] }