language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-09-28 14:24:45 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Pointlessly improve how we handle a crazy edge case, because my brain wouldn't let it go

Browse source
This commit is contained in:
Brian Carroll 2021-10-25 13:26:50 +02:00
parent 4e098be7fe
commit d996eee72e
1 changed files with 7 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

13
compiler/gen_wasm/src/code_builder.rs
View file

@ -5,11 +5,11 @@ use std::fmt::Debug;
use roc_module::symbol::Symbol; use roc_module::symbol::Symbol;
use crate::opcodes::*;
use crate::{ use crate::{
encode_f32, encode_f64, encode_i32, encode_i64, encode_u32, round_up_to_alignment, LocalId, encode_f32, encode_f64, encode_i32, encode_i64, encode_u32, round_up_to_alignment, LocalId,
FRAME_ALIGNMENT_BYTES, STACK_POINTER_GLOBAL_ID, FRAME_ALIGNMENT_BYTES, STACK_POINTER_GLOBAL_ID,
}; };
use crate::{opcodes::*, overwrite_padded_u32};
const DEBUG_LOG: bool = false; const DEBUG_LOG: bool = false;
@ -328,11 +328,12 @@ impl<'a> CodeBuilder<'a> {
if num_batches < 128 { if num_batches < 128 {
self.preamble[0] = num_batches as u8; self.preamble[0] = num_batches as u8;
} else { } else {
// We have 128+ batches of locals (extremely unlikely!) // We need more than 1 byte to encode num_batches!
let tmp = self.preamble.clone(); // This is a ridiculous edge case, so just pad to 5 bytes for simplicity
self.preamble.clear(); let old_len = self.preamble.len();
encode_u32(&mut self.preamble, num_batches); self.preamble.resize(old_len + 4, 0);
self.preamble.extend_from_slice(&tmp); self.preamble.copy_within(1..old_len, 5);
overwrite_padded_u32(&mut self.preamble[0..5], num_batches);
} }
} }