language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-09-26 13:29:12 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

clarify comment

Browse source
This commit is contained in:
Folkert 2022-09-18 01:00:36 +02:00
parent 270949aa07
commit daa7e72a2f
No known key found for this signature in database
GPG key ID: 1F17F6FFD112B97C
1 changed files with 4 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

4
crates/linker/src/generate_dylib/pe.rs
View file

@ -73,6 +73,10 @@ fn synthetic_export_dir(virtual_address: u32, custom_names: &[String]) -> Vec<u8
// The address hence points to a place in the .edata section. Such exports are
// called "forwarders". Because there is no actual definition, these exports don't
// show up when calling the `object` crate's .exports() method.
//
// It may turn out that we should actually not make our symbols forwarders. We can do this by
// adding a .text section with some NULL bytes before the .rdata section, and having the
// symbols point into this meaningless .text section.
let mut next_name_start =
directory.address_of_name_ordinals.get(LE) + custom_names.len() as u32 * 2;