language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-09-28 22:34:45 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Improve OptSize implementation in Roc

Browse source 
1. Use the llvm `Oz` pipeline.
2. Avoid adding extra optimization passes.

This shrunk rocci-bird by ~16%.
This commit is contained in:
Brendan Hansknecht 2024-04-28 22:52:07 -07:00
parent a323dd8e92
commit dc539f759d
No known key found for this signature in database
GPG key ID: 0EA784685083E75B
1 changed files with 8 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

11
crates/compiler/gen_llvm/src/llvm/build.rs
View file

@ -1124,7 +1124,11 @@ pub fn construct_optimization_passes<'a>(
} }
OptLevel::Size => { OptLevel::Size => {
pmb.set_optimization_level(OptimizationLevel::Default); pmb.set_optimization_level(OptimizationLevel::Default);
// 2 is equivalent to `-Oz`.
pmb.set_size_level(2);
// TODO: For some usecase, like embedded, it is useful to expose this and tune it. // TODO: For some usecase, like embedded, it is useful to expose this and tune it.
// This really depends on if inlining causes enough simplifications to reduce code size.
pmb.set_inliner_with_threshold(50); pmb.set_inliner_with_threshold(50);
} }
OptLevel::Optimize => { OptLevel::Optimize => {
@ -1134,9 +1138,10 @@ pub fn construct_optimization_passes<'a>(
} }
} }
// Add optimization passes for Size and Optimize. // Add extra optimization passes for Optimize.
if matches!(opt_level, OptLevel::Size | OptLevel::Optimize) { if matches!(opt_level, OptLevel::Optimize) {
// TODO figure out which of these actually help // TODO: figure out which of these actually help.
// Note, llvm probably already runs all of these as part of Aggressive.
// function passes // function passes