language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-08-03 03:42:17 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Do not create unnecessary scope in solve run_help

Browse source
This commit is contained in:
Agus Zubiaga 2024-05-30 20:18:59 -03:00
parent dd0e28240a
commit dcb2767b6e
No known key found for this signature in database
1 changed files with 8 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

17
crates/compiler/solve/src/solve.rs
View file

@ -135,12 +135,6 @@ fn run_help(
let mut pools = Pools::default();
// todo(agus): Do we need state here?
let state = State {
scope: Scope::new(None),
mark: Mark::NONE.next(),
};
let rank = Rank::toplevel();
let arena = Bump::new();
@ -181,7 +175,6 @@ fn run_help(
let state = solve(
&mut env,
types,
state,
rank,
problems,
aliases,
@ -240,7 +233,6 @@ enum Work<'a> {
fn solve(
env: &mut InferenceEnv,
mut can_types: Types,
mut state: State,
rank: Rank,
problems: &mut Vec<TypeError>,
aliases: &mut Aliases,
@ -250,14 +242,21 @@ fn solve(
awaiting_specializations: &mut AwaitingSpecializations,
params_pattern: Option<roc_can::pattern::Pattern>,
) -> State {
let scope = Scope::new(params_pattern);
let initial = Work::Constraint {
scope: &Scope::new(params_pattern),
scope: &scope.clone(),
rank,
constraint,
};
let mut stack = vec![initial];
let mut state = State {
scope,
mark: Mark::NONE.next(),
};
while let Some(work_item) = stack.pop() {
let (scope, rank, constraint) = match work_item {
Work::Constraint {