language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-09-26 13:29:12 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

mono code_gen_help: decref should use element alignment, not List alignment

Browse source
This commit is contained in:
Brian Carroll 2023-01-25 08:53:24 +00:00 • committed by Folkert
parent c2faaef092
commit e0b5247f3e
No known key found for this signature in database
GPG key ID: 1F17F6FFD112B97C
1 changed files with 3 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

8
crates/compiler/mono/src/code_gen_help/refcount.rs
View file

@ -74,7 +74,7 @@ pub fn refcount_stmt<'a>(
ModifyRc::DecRef(structure) => { ModifyRc::DecRef(structure) => {
match layout_interner.get(layout) { match layout_interner.get(layout) {
// Str has no children, so we might as well do what we normally do and call the helper. // Str has no children, so Dec is the same as DecRef.
Layout::Builtin(Builtin::Str) => { Layout::Builtin(Builtin::Str) => {
ctx.op = HelperOp::Dec; ctx.op = HelperOp::Dec;
refcount_stmt( refcount_stmt(
@ -139,7 +139,6 @@ pub fn refcount_generic<'a>(
ident_ids, ident_ids,
ctx, ctx,
layout_interner, layout_interner,
layout,
elem_layout, elem_layout,
structure, structure,
), ),
@ -725,7 +724,6 @@ fn refcount_list<'a>(
ident_ids: &mut IdentIds, ident_ids: &mut IdentIds,
ctx: &mut Context<'a>, ctx: &mut Context<'a>,
layout_interner: &mut STLayoutInterner<'a>, layout_interner: &mut STLayoutInterner<'a>,
layout: InLayout,
elem_layout: InLayout<'a>, elem_layout: InLayout<'a>,
structure: Symbol, structure: Symbol,
) -> Stmt<'a> { ) -> Stmt<'a> {
@ -774,7 +772,7 @@ fn refcount_list<'a>(
// //
let rc_ptr = root.create_symbol(ident_ids, "rc_ptr"); let rc_ptr = root.create_symbol(ident_ids, "rc_ptr");
let alignment = layout_interner.alignment_bytes(layout); let elem_alignment = layout_interner.alignment_bytes(elem_layout);
let ret_stmt = rc_return_stmt(root, ident_ids, ctx); let ret_stmt = rc_return_stmt(root, ident_ids, ctx);
let modify_list = modify_refcount( let modify_list = modify_refcount(
@ -782,7 +780,7 @@ fn refcount_list<'a>(
ident_ids, ident_ids,
ctx, ctx,
rc_ptr, rc_ptr,
alignment, elem_alignment,
arena.alloc(ret_stmt), arena.alloc(ret_stmt),
); );