language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-08-03 03:42:17 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Recover Erroneous in type

Browse source
This commit is contained in:
Ayaz Hafiz 2022-11-07 15:15:47 -06:00
parent 58020a55d6
commit e240b18b27
No known key found for this signature in database
GPG key ID: 0E2A37416A25EF58
2 changed files with 11 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

7
crates/compiler/solve/src/solve.rs
View file

@ -3040,7 +3040,6 @@ fn type_to_variable<'a>(
alias_variable,
AliasKind::Structural,
);
// let result = register(subs, rank, pools, content);
let result = register_with_known_var(subs, destination, rank, pools, content);
// We only want to unify the actual_var with the alias once
@ -3054,7 +3053,11 @@ fn type_to_variable<'a>(
result
}
Erroneous => {
let content = Content::Error;
// TODO: remove `Erroneous`, `Error` can always be used, and type problems known at
// this point can be reported during canonicalization.
let problem_index =
SubsIndex::push_new(&mut subs.problems, types.get_problem(&typ).clone());
let content = Content::Structure(FlatType::Erroneous(problem_index));
register_with_known_var(subs, destination, rank, pools, content)
}

6
crates/compiler/types/src/types.rs
View file

@ -417,6 +417,7 @@ pub enum TypeTag {
Variable(Variable),
RangedNumber(NumericRange),
/// A type error, which will code gen to a runtime error
/// The problem is at the index of the type tag
Erroneous,
// TypeExtension is implicit in the type slice
@ -507,6 +508,11 @@ impl Types {
.expect("typ is not a single tag union")
}
#[track_caller]
pub fn get_problem(&self, typ: &Index<TypeTag>) -> &Problem {
self.problems.get(typ).expect("typ is not an error")
}
pub fn record_fields_slices(
&self,
fields: RecordFields,