language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-09-26 13:29:12 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Report duplicate implementations for ability members

Browse source
This commit is contained in:
Ayaz Hafiz 2022-07-19 12:05:54 -04:00
parent 7b9b855dcc
commit e4af8af1a3
No known key found for this signature in database
GPG key ID: 0E2A37416A25EF58
4 changed files with 74 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

43
crates/compiler/can/src/def.rs
View file

@ -451,14 +451,7 @@ fn canonicalize_claimed_ability_impl<'a>(
};
match scope.lookup_ability_member_shadow(member_symbol) {
Some(impl_symbol) => {
// TODO: get rid of register_specializing_symbol
scope
.abilities_store
.register_specializing_symbol(impl_symbol, member_symbol);
Ok((member_symbol, impl_symbol))
}
Some(impl_symbol) => Ok((member_symbol, impl_symbol)),
None => {
env.problem(Problem::ImplementationNotFound {
member: member_symbol,
@ -514,11 +507,6 @@ fn canonicalize_claimed_ability_impl<'a>(
}
};
// TODO: get rid of register_specializing_symbol
scope
.abilities_store
.register_specializing_symbol(impl_symbol, member_symbol);
Ok((member_symbol, impl_symbol))
}
AssignedField::OptionalValue(_, _, _) => {
@ -596,20 +584,37 @@ fn canonicalize_opaque<'a>(
};
if let Some(impls) = opt_impls {
let mut impl_map: VecMap<Symbol, Symbol> = VecMap::default();
let mut impl_map: VecMap<Symbol, Loc<Symbol>> = VecMap::default();
for loc_impl in impls.extract_spaces().item.items {
match canonicalize_claimed_ability_impl(env, scope, ability, loc_impl) {
Ok((member, opaque_impl)) => {
impl_map.insert(member, opaque_impl);
let (member, impl_symbol) =
match canonicalize_claimed_ability_impl(env, scope, ability, loc_impl) {
Ok((member, impl_symbol)) => (member, impl_symbol),
Err(()) => continue,
};
match impl_map.insert(member, Loc::at(loc_impl.region, impl_symbol)) {
None => {
// TODO: get rid of register_specializing_symbol
scope
.abilities_store
.register_specializing_symbol(impl_symbol, member);
}
Some(old_impl_symbol) => {
env.problem(Problem::DuplicateImpl {
original: old_impl_symbol.region,
duplicate: loc_impl.region,
});
}
Err(()) => continue,
}
}
supported_abilities.push(OpaqueSupports::Implemented {
ability_name: ability,
impls: impl_map,
impls: impl_map
.into_iter()
.map(|(member, def)| (member, def.value))
.collect(),
});
} else if ability.is_builtin_ability() {
derived_abilities.push(Loc::at(region, ability));