language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-07-23 14:35:12 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Enable optional record field underivable error

Browse source
This commit is contained in:
Ayaz Hafiz 2022-08-09 08:48:21 -07:00
parent 55fe1df995
commit e77e53f37b
No known key found for this signature in database
GPG key ID: 0E2A37416A25EF58
2 changed files with 17 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

27
crates/compiler/solve/src/ability.rs
View file

@ -4,7 +4,9 @@ use roc_collections::{VecMap, VecSet};
use roc_error_macros::{internal_error, todo_abilities};
use roc_module::symbol::Symbol;
use roc_region::all::{Loc, Region};
use roc_solve_problem::{NotDerivableContext, TypeError, UnderivableReason, Unfulfilled};
use roc_solve_problem::{
NotDerivableContext, NotDerivableDecode, TypeError, UnderivableReason, Unfulfilled,
};
use roc_types::num::NumericRange;
use roc_types::subs::{
instantiate_rigids, Content, FlatType, GetSubsSlice, Rank, RecordFields, Subs, Variable,
@ -837,19 +839,18 @@ impl DerivableVisitor for DeriveDecoding {
var: Variable,
fields: RecordFields,
) -> Result<Descend, NotDerivable> {
let has_optional_field = subs
.get_subs_slice(fields.record_fields())
.iter()
.any(|field| matches!(field, RecordField::Optional(..)));
if has_optional_field {
Err(NotDerivable {
var,
context: NotDerivableContext::NoContext,
})
} else {
Ok(Descend(true))
for (field_name, _, field) in fields.iter_all() {
if matches!(subs[field], RecordField::Optional(..)) {
return Err(NotDerivable {
var,
context: NotDerivableContext::Decode(NotDerivableDecode::OptionalRecordField(
subs[field_name].clone(),
)),
});
}
}
Ok(Descend(true))
}
#[inline(always)]