language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-09-26 13:29:12 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Invalidate layout-cached variables correctly after merging

Browse source
This commit is contained in:
Ayaz Hafiz 2022-08-29 14:16:03 -05:00
parent 66e65714b9
commit ea2e5d171a
No known key found for this signature in database
GPG key ID: 0E2A37416A25EF58
4 changed files with 123 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

23
crates/compiler/mono/src/layout.rs
View file

@ -290,6 +290,22 @@ impl<'a> LayoutCache<'a> {
self.raw_function_cache.pop();
}
/// Invalidates the list of given root variables.
/// Usually called after unification, when merged variables with changed contents need to be
/// invalidated.
pub fn invalidate(&mut self, vars: impl IntoIterator<Item = Variable>) {
for var in vars.into_iter() {
for layer in self.cache.iter_mut().rev() {
layer.0.remove(&var);
roc_tracing::debug!(?var, "invalidating cached layout");
}
for layer in self.raw_function_cache.iter_mut().rev() {
layer.0.remove(&var);
roc_tracing::debug!(?var, "invalidating cached layout");
}
}
}
#[cfg(debug_assertions)]
pub fn statistics(&self) -> (CacheStatistics, CacheStatistics) {
(self.stats, self.raw_function_stats)
@ -1970,6 +1986,13 @@ macro_rules! cached_or_impl {
if criteria.is_cacheable() {
// The computed layout is cacheable; insert it.
dbg!((
$var,
roc_types::subs::SubsFmtContent(
$self.subs.get_content_without_compacting($var),
$self.subs
)
));
$self
.cache
.$insert($self.subs, $var, result, criteria.cache_metadata());