mirror of
https://github.com/roc-lang/roc.git
synced 2025-09-27 22:09:09 +00:00
refactor solve_module
This commit is contained in:
parent
de8ad07f2e
commit
ed592d3d10
2 changed files with 60 additions and 30 deletions
|
@ -2,6 +2,7 @@ use crate::solve;
|
|||
use roc_can::constraint::Constraint;
|
||||
use roc_can::module::Module;
|
||||
use roc_collections::all::{MutMap, SendMap};
|
||||
use roc_module::ident::Lowercase;
|
||||
use roc_module::symbol::Symbol;
|
||||
use roc_types::solved_types::{Solved, SolvedType};
|
||||
use roc_types::subs::{Subs, VarStore, Variable};
|
||||
|
@ -20,15 +21,42 @@ pub fn solve_module(
|
|||
constraint: Constraint,
|
||||
var_store: VarStore,
|
||||
) -> (Solved<Subs>, SolvedModule) {
|
||||
let exposed_vars_by_symbol: Vec<(Symbol, Variable)> = module.exposed_vars_by_symbol;
|
||||
let Module {
|
||||
exposed_vars_by_symbol,
|
||||
aliases,
|
||||
rigid_variables,
|
||||
..
|
||||
} = module;
|
||||
|
||||
let (solved_subs, solved_env, problems) =
|
||||
run_solve(aliases, rigid_variables, constraint, var_store);
|
||||
|
||||
let solved_types = make_solved_types(&solved_env, &solved_subs, &exposed_vars_by_symbol);
|
||||
|
||||
let solved_module = SolvedModule {
|
||||
exposed_vars_by_symbol,
|
||||
solved_types,
|
||||
problems,
|
||||
aliases: solved_env.aliases,
|
||||
};
|
||||
|
||||
(solved_subs, solved_module)
|
||||
}
|
||||
|
||||
pub fn run_solve(
|
||||
aliases: MutMap<Symbol, Alias>,
|
||||
rigid_variables: MutMap<Variable, Lowercase>,
|
||||
constraint: Constraint,
|
||||
var_store: VarStore,
|
||||
) -> (Solved<Subs>, solve::Env, Vec<solve::TypeError>) {
|
||||
let env = solve::Env {
|
||||
vars_by_symbol: SendMap::default(),
|
||||
aliases: module.aliases,
|
||||
aliases,
|
||||
};
|
||||
|
||||
let mut subs = Subs::new(var_store.into());
|
||||
|
||||
for (var, name) in module.rigid_variables {
|
||||
for (var, name) in rigid_variables {
|
||||
subs.rigid_var(var, name);
|
||||
}
|
||||
|
||||
|
@ -38,21 +66,30 @@ pub fn solve_module(
|
|||
|
||||
// Run the solver to populate Subs.
|
||||
let (solved_subs, solved_env) = solve::run(&env, &mut problems, subs, &constraint);
|
||||
|
||||
(solved_subs, solved_env, problems)
|
||||
}
|
||||
|
||||
fn make_solved_types(
|
||||
solved_env: &solve::Env,
|
||||
solved_subs: &Solved<Subs>,
|
||||
exposed_vars_by_symbol: &[(Symbol, Variable)],
|
||||
) -> MutMap<Symbol, SolvedType> {
|
||||
let mut solved_types = MutMap::default();
|
||||
|
||||
for (symbol, alias) in solved_env.aliases {
|
||||
for (symbol, alias) in solved_env.aliases.iter() {
|
||||
let mut args = Vec::with_capacity(alias.vars.len());
|
||||
|
||||
for loc_named_var in alias.vars {
|
||||
let (name, var) = loc_named_var.value;
|
||||
for loc_named_var in alias.vars.iter() {
|
||||
let (name, var) = &loc_named_var.value;
|
||||
|
||||
args.push((name.clone(), SolvedType::new(&solved_subs, var)));
|
||||
args.push((name.clone(), SolvedType::new(&solved_subs, *var)));
|
||||
}
|
||||
|
||||
let solved_type = SolvedType::from_type(&solved_subs, alias.typ);
|
||||
let solved_alias = SolvedType::Alias(symbol, args, Box::new(solved_type));
|
||||
let solved_type = SolvedType::from_type(&solved_subs, &alias.typ);
|
||||
let solved_alias = SolvedType::Alias(*symbol, args, Box::new(solved_type));
|
||||
|
||||
solved_types.insert(symbol, solved_alias);
|
||||
solved_types.insert(*symbol, solved_alias);
|
||||
}
|
||||
|
||||
// exposed_vars_by_symbol contains the Variables for all the Symbols
|
||||
|
@ -66,12 +103,5 @@ pub fn solve_module(
|
|||
solved_types.insert(*symbol, solved_type);
|
||||
}
|
||||
|
||||
let solved_module = SolvedModule {
|
||||
exposed_vars_by_symbol,
|
||||
solved_types,
|
||||
problems,
|
||||
aliases: env.aliases,
|
||||
};
|
||||
|
||||
(solved_subs, solved_module)
|
||||
solved_types
|
||||
}
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue