language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-09-26 13:29:12 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Merge pull request #4887 from roc-lang/weakening-5

Browse source 
Finish weakening let-bindings
This commit is contained in:
Ayaz 2023-01-17 12:47:12 -06:00 • committed by GitHub
commit ed7123ed5b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
11 changed files with 109 additions and 69 deletions
Download patch file Download diff file Expand all files Collapse all files

18
crates/compiler/constrain/src/expr.rs
View file

@ -3609,9 +3609,7 @@ pub fn rec_defs_help_simple(
}
_ => true, // this must be a function
});
// TODO(weakening)
#[allow(clippy::logic_bug)]
Generalizable(generalizable || true)
Generalizable(generalizable)
};
for index in range {
@ -3861,11 +3859,11 @@ fn is_generalizable_expr(mut expr: &Expr) -> bool {
| ExpectFx { .. }
| Dbg { .. }
| TypedHole(_)
| RuntimeError(..) => return false,
// TODO(weakening)
Var(_, _) | AbilityMember(_, _, _) | Tag { .. } | ZeroArgumentTag { .. } => {
return true
}
| RuntimeError(..)
| ZeroArgumentTag { .. }
| Tag { .. }
| AbilityMember(..)
| Var(..) => return false,
}
}
}
@ -3901,9 +3899,7 @@ fn rec_defs_help(
let generalizable = defs
.iter()
.all(|d| is_generalizable_expr(&d.loc_expr.value));
// TODO(weakening)
#[allow(clippy::logic_bug)]
Generalizable(generalizable || true)
Generalizable(generalizable)
};
for def in defs {