Merge remote-tracking branch 'origin/main' into upgrade-llvm-zig

.github/workflows/ubuntu_x86_64.yml

@@ -29,11 +29,6 @@ jobs:
       - name: roc format check on builtins
         run: cargo run --locked --release format --check crates/compiler/builtins/roc
 
-      - name: run fuzz tests
-        run: |
-          cargo +nightly-2024-02-03 install --locked cargo-fuzz
-          cd crates/compiler/test_syntax/fuzz && cargo +nightly-2024-02-03 fuzz run -j4 fuzz_expr --sanitizer=none -- -dict=dict.txt -max_total_time=60
-
       - name: ensure there are no unused dependencies
         run: cargo +nightly-2024-02-03 udeps --all-targets
 
@@ -67,3 +62,8 @@ jobs:
 
       - name: test website build script
         run: bash www/build.sh
+
+      - name: run fuzz tests - ok to merge if this one fails # for now!
+        run: |
+          cargo +nightly-2024-02-03 install --locked cargo-fuzz
+          cd crates/compiler/test_syntax/fuzz && cargo +nightly-2024-02-03 fuzz run -j4 fuzz_expr --sanitizer=none -- -dict=dict.txt -max_total_time=60

crates/compiler/fmt/src/expr.rs

@@ -513,6 +513,7 @@ fn requires_space_after_unary(item: &Expr<'_>) -> bool {
             is_negative,
         } => *is_negative,
         Expr::RecordUpdater(..) => true,
+        Expr::RecordAccess(inner, _field) => requires_space_after_unary(inner),
         Expr::Apply(inner, _, _) => requires_space_after_unary(&inner.value),
         Expr::TrySuffix { target: _, expr } => requires_space_after_unary(expr),
         Expr::SpaceAfter(inner, _) | Expr::SpaceBefore(inner, _) => {

crates/compiler/test_syntax/tests/snapshots/pass/num_bang_amp_z_dot_t.expr.formatted.roc

@@ -0,0 +1,2 @@
+4
+! &z.t

crates/compiler/test_syntax/tests/snapshots/pass/num_bang_amp_z_dot_t.expr.result-ast

@@ -0,0 +1,49 @@
+@0-8 SpaceAfter(
+    Defs(
+        Defs {
+            tags: [
+                EitherIndex(2147483648),
+            ],
+            regions: [
+                @0-1,
+            ],
+            space_before: [
+                Slice<roc_parse::ast::CommentOrNewline> { start: 0, length: 0 },
+            ],
+            space_after: [
+                Slice<roc_parse::ast::CommentOrNewline> { start: 0, length: 0 },
+            ],
+            spaces: [],
+            type_defs: [],
+            value_defs: [
+                Stmt(
+                    @0-1 Num(
+                        "4",
+                    ),
+                ),
+            ],
+        },
+        @2-8 SpaceBefore(
+            UnaryOp(
+                @4-6 SpaceBefore(
+                    RecordAccess(
+                        RecordUpdater(
+                            "z",
+                        ),
+                        "t",
+                    ),
+                    [
+                        Newline,
+                    ],
+                ),
+                @2-3 Not,
+            ),
+            [
+                Newline,
+            ],
+        ),
+    ),
+    [
+        Newline,
+    ],
+)

crates/compiler/test_syntax/tests/snapshots/pass/num_bang_amp_z_dot_t.expr.roc

@@ -0,0 +1,3 @@
+4
+!
+&z.t

crates/compiler/test_syntax/tests/test_snapshots.rs

@@ -514,6 +514,7 @@ mod test_snapshots {
         pass/not_multiline_string.expr,
         pass/not_record_updater.expr,
         pass/not_tag.expr,
+        pass/num_bang_amp_z_dot_t.expr,
         pass/number_literal_suffixes.expr,
         pass/old_app_header.full,
         pass/old_interface_header.header,