language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-10-03 00:24:34 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Wasm: tweaks from self-review

Browse source
This commit is contained in:
Brian Carroll 2022-01-14 18:50:52 +00:00
parent c5134fa015
commit f4137013cb
3 changed files with 17 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

5
compiler/gen_wasm/src/wasm_module/opcodes.rs
View file

@ -185,6 +185,9 @@ pub enum OpCode {
F64REINTERPRETI64 = 0xbf,
}
/// The format of the *immediate* operands of an operator
/// Immediates appear directly in the byte stream after the opcode,
/// rather than being popped off the value stack. These are the possible forms.
enum OpImmediates {
NoImmediate,
Byte1,
@ -248,7 +251,7 @@ impl From<OpCode> for OpImmediates {
| I64REINTERPRETF64 | F32REINTERPRETI32 | F64REINTERPRETI64 => NoImmediate,
// Catch-all in case of an invalid cast from u8 to OpCode while parsing binary
// (rustc keeps this code, it has been verified in Compiler Explorer)
// (rustc keeps this code, I verified in Compiler Explorer)
#[allow(unreachable_patterns)]
_ => internal_error!("Unknown Wasm instruction 0x{:02x}", op as u8),
}