language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-09-27 13:59:08 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Update from PR comments

Browse source
This commit is contained in:
Sam Mohr 2024-07-07 18:33:20 -07:00
parent f415017c90
commit fe1b6d71fc
No known key found for this signature in database
GPG key ID: EA41D161A3C1BC99
17 changed files with 377 additions and 176 deletions
Download patch file Download diff file Expand all files Collapse all files

12
crates/reporting/src/error/canonicalize.rs
View file

@ -2447,25 +2447,25 @@ fn pretty_runtime_error<'b>(
title = "UNAPPLIED OLD-STYLE RECORD BUILDER";
}
RuntimeError::EmptyNewRecordBuilder(region) => {
RuntimeError::EmptyRecordBuilder(region) => {
doc = alloc.stack([
alloc.reflow("This record builder has no fields:"),
alloc.region(lines.convert_region(region), severity),
alloc.note("We need at least two fields to combine their values into a record."),
alloc.reflow("I need at least two fields to combine their values into a record."),
]);
title = "EMPTY RECORD BUILDER";
}
RuntimeError::SingleFieldNewRecordBuilder(region) => {
RuntimeError::SingleFieldRecordBuilder(region) => {
doc = alloc.stack([
alloc.reflow("This record builder only has one field:"),
alloc.region(lines.convert_region(region), severity),
alloc.note("We need at least two fields to combine their values into a record."),
alloc.reflow("I need at least two fields to combine their values into a record."),
]);
title = "NOT ENOUGH FIELDS IN RECORD BUILDER";
}
RuntimeError::OptionalFieldInNewRecordBuilder {
RuntimeError::OptionalFieldInRecordBuilder {
record: record_region,
field: field_region,
} => {
@ -2476,7 +2476,7 @@ fn pretty_runtime_error<'b>(
lines.convert_region(field_region),
severity,
),
alloc.note("Record builders can only have required values for their fields."),
alloc.reflow("Record builders can only have required values for their fields."),
]);
title = "OPTIONAL FIELD IN RECORD BUILDER";

2
crates/reporting/src/error/type.rs
View file

@ -1175,7 +1175,7 @@ fn to_expr_report<'b>(
alloc.reflow(" to assign the field directly.")
])
}
CalledVia::NewRecordBuilder => {
CalledVia::RecordBuilder => {
alloc.concat([
alloc.note(""),
alloc.reflow("Record builders need a mapper function before the "),