Commit graph

3081 commits

Author SHA1 Message Date
Ayaz Hafiz
13bb657b97
Follow recursive pointers in mono IR checker to not appear on top-level 2022-12-27 12:47:53 -06:00
Ayaz Hafiz
ce61386d0a
Expose set and representation to crate 2022-12-27 12:47:04 -06:00
Ayaz Hafiz
23fc7f1413
Appropriately substitute symbols in switch conditions
Closes #4557
2022-12-27 12:29:23 -06:00
Ayaz
4dbe90db93
Merge pull request #4807 from joshuawarner32/fix-unify
Fix bug in unification of tag args in polymorphic contexts
2022-12-27 11:24:24 -06:00
Ayaz Hafiz
a818b810f2
Better name for #4717 repro case 2022-12-27 11:05:12 -06:00
Ayaz Hafiz
d23d0b9b88
Remove unneeded branch when extending lambda dispatch with closure args
If we pass ClosureInfo that indicates that a lambda captures, then when
we extend the lambda's argument list with the lambda set it appears it,
the extension must necessarily be material.
2022-12-27 10:56:23 -06:00
Ayaz Hafiz
25117bf50e
More do not ignore the specialized layout 2022-12-27 10:52:47 -06:00
Ayaz Hafiz
6ed1ad9fd5
Do not ignore layout, base it off specialization 2022-12-27 10:48:24 -06:00
Ayaz Hafiz
e7aaeb931a
Add a comment regarding behavior of extend_argument_list_for_named 2022-12-27 10:42:35 -06:00
Ayaz Hafiz
830843da82
Remove unused extend_argument_list 2022-12-27 10:40:09 -06:00
Ayaz Hafiz
468f76a424
Remove unused layout cache parameters 2022-12-27 10:39:44 -06:00
Ayaz Hafiz
3e906855e3
Extend called lambda argument lists only with explicit lambda names 2022-12-27 10:37:25 -06:00
Ayaz Hafiz
679557e44e
ProcLayout::new is crate-public 2022-12-27 10:33:38 -06:00
Ayaz Hafiz
8431b27282
Remove redundant parameter in from_raw_named
The captures niche is already accounted for by the lambda name, so we
don't need that as an extra param.
2022-12-27 10:30:07 -06:00
Ayaz Hafiz
e89f5ad6e5
Mark a couple functions as crate-exposed 2022-12-27 10:28:00 -06:00
Ayaz Hafiz
0b57d2f74f
Remove unneeded import 2022-12-27 10:27:19 -06:00
Ayaz Hafiz
198417c183
Remove ProcLayout::from_raw 2022-12-27 10:25:43 -06:00
Ayaz Hafiz
7a6e68861c
Account for non-capturing functions in larger lambda sets passed to HOLLs
Previously, if the lambda set passed to a HOLL contained any function
that captured, we would assume that the specialization of the HOLL we
should make for each function in the lambda set that we dispatch to
should capture.

This is not right. Instead, we should specialize for each lambda in the
set passed to the HOLL. The present patch enforces that, making sure
that for each lambda in the set, we compute the exact proc layout needed
to call the lambda, based on the captures of the specific lambda in the
set, rather than looking at the set entirely.
2022-12-27 10:22:18 -06:00
Ayaz Hafiz
bb0493918e
Update more usages of from_raw 2022-12-27 09:54:18 -06:00
Ayaz Hafiz
38920b98fa
Debug missing lambda names 2022-12-27 09:54:12 -06:00
Ayaz Hafiz
ccd68b70e1
Do not associate top-level accessor thunks as closures
Leftover follow-up to #4645
2022-12-27 09:49:51 -06:00
Ayaz Hafiz
fe58a0591b
Migrate some more uses of from_raw 2022-12-27 09:27:29 -06:00
Ayaz Hafiz
54bb258aac
Remove stale uniqueness inference comment 2022-12-27 09:26:08 -06:00
Ayaz Hafiz
1e847efbfe
Correctly choose specialized shapes for anonymous closures 2022-12-27 09:18:41 -06:00
Ayaz Hafiz
593344f5c5
Determine the proc layout based on captures of an individual lambda
Previously, we determined whether a closure argument should be added to
the proc layout of a compiled function by checking whether the lambda
set was material at all. But, the extension for a single function should
be added if and only if the function itself captures.
2022-12-27 09:15:21 -06:00
Anton-4
c3b0295a92
Merge pull request #4813 from joshuawarner32/test_syntax
Move syntax tests to a dedicated crate
2022-12-27 13:15:01 +01:00
Anton-4
f0ea60df51
use latest cli platform, added wasm repl build test 2022-12-27 11:31:15 +01:00
Joshua Warner
bfeddc470a
Move syntax tests to a dedicated crate
* test_fmt moves out of fmt crate
* test_parse _mostly_ moves out of parse crate and into `test_snapshots.rs` (some simple tests remain)
* now there's only two fuzz targets, fuzz_expr and fuzz_module, that cover both parsing and formatting
* added a system to auto-add new snapshot entries for new test files
* took some commented-out tests in `test_parse` and converted them to snapshot tests
* moved test_fmt's verification of formatting consistency into test_snapshots
* fixed a huge derp on my part where the fmt fuzzer in #4758 was completely useless (broken by refactoring just prior to submitting the PR)
* fixed a formatting bug found by fuzzing (bound_variable.expr.roc) - that I missed earlier due to ^^^ that derp
* no longer have roc_test_utils as a dependency in fmt - which was causing problems for the wasm build
2022-12-26 22:50:24 -08:00
Richard Feldman
5227b5ff43
c l i p p y 2022-12-27 00:31:54 -05:00
Richard Feldman
8606faa9db
Move builtin module-level docs to the top 2022-12-26 23:57:27 -05:00
Richard Feldman
b749ac28c9
Use module-level comments for top-level docs 2022-12-26 23:55:54 -05:00
Richard Feldman
3171a15ed0
Parse header_docs 2022-12-26 23:15:48 -05:00
Richard Feldman
74e16c5293
Clarify a comment 2022-12-26 23:15:48 -05:00
Joshua Warner
8abd5cf605
Fix bug in unification of tag args in polymorphic contexts 2022-12-26 13:01:31 -08:00
Richard Feldman
8c40d72a1f
Don't add exposed modules to imported_modules 2022-12-26 04:35:23 -05:00
Ayaz Hafiz
877714ff91
We prefer slices 2022-12-25 16:56:00 -06:00
Ayaz Hafiz
ec0f1ce757
Update mono test name 2022-12-25 16:56:00 -06:00
Ayaz Hafiz
2a64b18c98
Update mono tests 2022-12-25 16:56:00 -06:00
Ayaz Hafiz
fbfc429bc5
Add gen-test for #4732 2022-12-25 16:55:59 -06:00
Ayaz Hafiz
a8693e6102
Order list-min-size tests in descending order
Some of the head-constructor tests we generate can be supersets of other tests.
Edges must be ordered so that more general tests always happen after their
specialized variants.

For example, patterns

  [1, ..] -> ...
  [2, 1, ..] -> ...

may generate the edges

  ListLen(>=1) -> <rest>
  ListLen(>=2) -> <rest>

but evaluated in exactly this order, the second edge is never reachable.
The necessary ordering is

  ListLen(>=2) -> <rest>
  ListLen(>=1) -> <rest>

Closes #4732
2022-12-25 16:55:58 -06:00
Ayaz Hafiz
a295e7ac3d
Allow any int in switch condition layout 2022-12-25 16:55:37 -06:00
Richard Feldman
a663634e30
Add a comment 2022-12-25 17:15:53 -05:00
Richard Feldman
e5c5ae3e3f
Make a debug_assert! more precise 2022-12-25 17:13:42 -05:00
Richard Feldman
73fa34ba31
Only add extra imported modules when it's the root 2022-12-24 22:50:47 -05:00
Richard Feldman
1e0f5c2b28
Fix missing shorthands when importing packages 2022-12-24 22:49:40 -05:00
Richard Feldman
c925686443
Add some debug_assert! checks 2022-12-24 22:40:44 -05:00
Richard Feldman
5c80657bb2
Update some comments and docs 2022-12-24 22:32:16 -05:00
Richard Feldman
52bbe0062f
Drop an unnecessary scope block 2022-12-24 22:32:16 -05:00
Richard Feldman
34417f5692
clippy 2022-12-24 22:32:16 -05:00
Richard Feldman
5e3d808a61
roc format 2022-12-24 22:32:15 -05:00